move to mobile platform targets to net7 #2624
Conversation
bruno-garcia
requested review from
bitsandfoxes and
jamescrosswell
as code owners
| @@ -29,9 +29,11 @@ internal static class CollectionsExtensions | |||
| } | |||
| } | |||
|
|
|||
| #if !NET8_0_OR_GREATER | |||
There was a problem hiding this comment.
Technically not needed yet, will be needed when adding .NET 8: https://github.com/getsentry/sentry-dotnet/pull/2617/files#diff-ebf7bc6beaaf9dacfb725d68b7126baccbe823abd28dda757213831c04639774 and as I copied this over from the other PR, here it is.
bruno-garcia
changed the title
|
Need to our sample apps on |
| @@ -220,7 +220,9 @@ private static void AndroidEnvironment_UnhandledExceptionRaiser(object? _, Raise | |||
| return null; | |||
| } | |||
|
|
|||
| #pragma warning disable CS0618 // Type or member is obsolete | |||
There was a problem hiding this comment.
What will be the trigger for when we remove these? When the offending members actually get removed from the dotnet framework?
There was a problem hiding this comment.
it's binding to an native API that's deprecated
|
All looks good to me... assuming we delay merging until November though (when .NET 8.0 is officially released and we upgrade our tooling)? |
We merge into #2631 where we collect all breaking changes. We can make preview releases from the branch. In Nov we merge into |
Resolves #2623