Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to mobile platform targets to net7 #2624

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Conversation

bruno-garcia
Copy link
Member

Resolves #2623

@@ -29,9 +29,11 @@ internal static class CollectionsExtensions
}
}

#if !NET8_0_OR_GREATER
Copy link
Member Author

@bruno-garcia bruno-garcia Sep 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not needed yet, will be needed when adding .NET 8: https://github.com/getsentry/sentry-dotnet/pull/2617/files#diff-ebf7bc6beaaf9dacfb725d68b7126baccbe823abd28dda757213831c04639774 and as I copied this over from the other PR, here it is.

@bruno-garcia bruno-garcia mentioned this pull request Sep 16, 2023
3 tasks
@bruno-garcia bruno-garcia changed the title move to net7 mobile move to mobile platform targets to net7 Sep 16, 2023
@jamescrosswell
Copy link
Collaborator

Need to our sample apps on net7-ios (see #2540 (comment)) and net8-ios as well presumably.

@@ -220,7 +220,9 @@ private static void AndroidEnvironment_UnhandledExceptionRaiser(object? _, Raise
return null;
}

#pragma warning disable CS0618 // Type or member is obsolete
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will be the trigger for when we remove these? When the offending members actually get removed from the dotnet framework?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's binding to an native API that's deprecated

@jamescrosswell
Copy link
Collaborator

All looks good to me... assuming we delay merging until November though (when .NET 8.0 is officially released and we upgrade our tooling)?

@bruno-garcia bruno-garcia changed the base branch from main to feat/4.0.0 September 18, 2023 13:15
@bruno-garcia bruno-garcia mentioned this pull request Sep 18, 2023
@bruno-garcia
Copy link
Member Author

All looks good to me... assuming we delay merging until November though (when .NET 8.0 is officially released and we upgrade our tooling)?

We merge into #2631 where we collect all breaking changes. We can make preview releases from the branch. In Nov we merge into main and release 4.0.0

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bruno-garcia bruno-garcia merged commit a4efd31 into feat/4.0.0 Sep 18, 2023
17 checks passed
@bruno-garcia bruno-garcia deleted the ref/drop-net6-mobile branch September 18, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for .NET 6 Mobile
3 participants