Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app.in_foreground searchable #43964

Merged
merged 9 commits into from
Feb 6, 2023
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Feb 1, 2023

Make app.in_foreground searchable.

Docs PR: getsentry/develop#728
Relay PR: getsentry/relay#1578
Meta issue: getsentry/team-mobile#36

Follow up #44157

@marandaneto marandaneto changed the title Make app.in_foreground and thread.main searchable Make app.in_foreground and thread.main searchable Feb 1, 2023
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Feb 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

size-limit report 📦

Path Size
src/sentry/static/sentry/dist/entrypoints/app.js 19.6 KB (+0.22% 🔺)
src/sentry/static/sentry/dist/entrypoints/sentry.css 32.99 KB (0%)

@marandaneto marandaneto changed the title Make app.in_foreground and thread.main searchable Make app.in_foreground searchable Feb 6, 2023
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants