wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 #4222
Conversation
wgpu-types/src/lib.rs
Outdated
| /// - Metal | ||
| /// - OpenGL | ||
| const SHADER_UNUSED_VERTEX_OUTPUT = 1 << 54; | ||
|
|
||
| // 54..59 available |
There was a problem hiding this comment.
Yeah, this was missed in the original as well: #4116 (review)
There was a problem hiding this comment.
Either way, fixed here!
…x-rs#4116) * wgpu-core: Only produce StageError::InputNotConsumed on DX11/DX12 This error only exists due to an issue with naga's HLSL support: gfx-rs/naga#1945 The WGPU spec itself allows vertex shader outputs that are not consumed by the fragment shader. Until the issue is fixed, we can allow unconsumed outputs on all platforms other than DX11/DX12. * Add Features::SHADER_UNUSED_VERTEX_OUTPUT to allow disabling check * Pick an unused feature id
|
I'm not 100% sure what to do about this. 0.18 is slated to release in 2 weeks, if possible I don't really want to do another patch release so close, but if this is a serious problem in the wild, we can do it. |
Sure, but who knows when will |
|
Incidentally, just had a discussion with @Wumpf to get egui_wgpu to release sooner after a wgpu release. Either way, fair enough, I'll try to deal with this soon-ish. |
If this will actually happen, we can live for a few weeks without this backport, using our fork of |
|
Alright, I'm going to merge this as that's easy, once 0.18 comes out, I'll talk with the egui people about a release, and if there are issues, we'll follow threw with the patch release. |
|
Alright, thank you! |
This is a backport of #4116 to the
v0.17branch.To be honest, I don't know what exactly is to be done with
CHANGELOG.mdin this case, so I left it alone. As in, what (if any) the next version should be in there.