feat(api): enhance Actions Secrets Management API for repository #30656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add endpoint to list repository action secrets in API routes
- Implement `ListActionsSecrets` function to retrieve action secrets from the database
- Update Swagger documentation to include the new `/repos/{owner}/{repo}/actions/secrets` endpoint
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/api
lunny
approved these changes
Apr 23, 2024
GiteaBot
added
lgtm/need 1
|
It's better to have integration tests. |
- Remove owner variable and direct owner ID reference in `ListActionsSecrets` function. Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Add a new test case for listing repository secrets in the API integration tests Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
- Refactor API routing for actions, secrets, variables, and runners into a new `actionsGroup` function - Introduce a new `actionAPI` struct to encapsulate action-related API functions Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
wxiaoguang
reviewed
Apr 23, 2024
wxiaoguang
reviewed
Apr 24, 2024
- Add `actions` package import and define new routes for actions, secrets, variables, and runners in `api.go`. - Refactor action-related API functions into `Action` struct methods in `org/action.go` and `repo/action.go`. - Remove `actionAPI` struct and related functions, replacing them with `NewAction()` calls. - Rename `variables.go` to `action.go` in `org` directory. - Delete `runners.go` and `secrets.go` in both `org` and `repo` directories, consolidating their content into `action.go`. - Update copyright year and add new imports in `org/action.go`. - Implement `API` interface in `services/actions/interface.go` for action-related methods. - Remove individual action-related functions and replace them with methods on the `Action` struct in `repo/action.go`. Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
pull-request-size
bot
added
size/XL
lunny
reviewed
Apr 24, 2024
GiteaBot
added
lgtm/done
- Update method receiver from `*Action` to `Action` - Update method signatures to remove receiver argument - Update swagger operation comments to reflect changes Signed-off-by: appleboy <appleboy.tw@gmail.com>
- Change the expected status from `http.StatusNotFound` to `http.StatusMethodNotAllowed` in the APIRepoSecrets test. Signed-off-by: appleboy <appleboy.tw@gmail.com>
lunny
reviewed
Apr 25, 2024
appleboy
commented
Apr 25, 2024
appleboy
commented
Apr 25, 2024
lunny
approved these changes
Apr 26, 2024
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2024
* giteaofficial/main: feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656) Fix code search input for different views (go-gitea#30678) Fix incorrect object id hash function (go-gitea#30708) Add route handler info for debugging purpose (go-gitea#30705) Bump htmx version to 1.9.12 (go-gitea#30711)
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 27, 2024
* origin/main: Replace deprecated `math/rand` functions (go-gitea#30733) Make Ctrl+Enter work for issue/comment edit (go-gitea#30720) Rename migration package name for 1.22-rc1 (go-gitea#30730) Issue card improvements (go-gitea#30687) Don't show loading indicators when refreshing the system status (go-gitea#30712) Add some tests to clarify the "must-change-password" behavior (go-gitea#30693) Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686) Update JS dependencies (go-gitea#30713) Improve diff stats bar (go-gitea#30669) Remove unused parameter for some functions in `services/mirror` (go-gitea#30724) Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573) Suppress browserslist warning in webpack target (go-gitea#30571) [skip ci] Updated translations via Crowdin Diff color enhancements, add line number background (go-gitea#30670) feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656) Fix code search input for different views (go-gitea#30678) Fix incorrect object id hash function (go-gitea#30708)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListActionsSecretsfunction to retrieve action secrets from the database/repos/{owner}/{repo}/actions/secretsendpointactionspackage import and define new routes for actions, secrets, variables, and runners inapi.go.Actionstruct methods inorg/action.goandrepo/action.go.actionAPIstruct and related functions, replacing them withNewAction()calls.variables.gotoaction.goinorgdirectory.runners.goandsecrets.goin bothorgandrepodirectories, consolidating their content intoaction.go.org/action.go.APIinterface inservices/actions/interface.gofor action-related methods.Actionstruct inrepo/action.go.