Fix code search input for different views #30678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
modifies/go
|
When debugging, I also removed the unused Screentshots:
|
lunny
approved these changes
Apr 24, 2024
GiteaBot
added
lgtm/need 1
silverwind
reviewed
Apr 24, 2024
templates/repo/home.tmpl
Outdated
| @@ -136,7 +138,7 @@ | |||
| </div> | |||
| {{template "repo/cite/cite_modal" .}} | |||
| {{end}} | |||
| {{if and (not $isHomepage) (not .IsViewFile) (not .IsBlame)}} | |||
| {{if and (not $isHomepage) (not .IsViewFile) (not .IsBlame)}}{{/* IsViewDirectory (not home) */}} | |||
There was a problem hiding this comment.
Add a variable for IsViewDirectory?
There was a problem hiding this comment.
Don't think so, as this is a quick bug fix, do not want to introduce any potential regression.
There was a problem hiding this comment.
So we need to remember adding (not .IsXXX) here when adding a new page?
There was a problem hiding this comment.
I think we need to rewrite the page at that time, instead of introducing more if tricks.
There was a problem hiding this comment.
Agree. So can you add TODO or FIXME here, for avoiding forgetting this.
There was a problem hiding this comment.
Suggested change
| {{if and (not $isHomepage) (not .IsViewFile) (not .IsBlame)}}{{/* IsViewDirectory (not home) */}} | |
| {{if and (not $isHomepage) (not .IsViewFile) (not .IsBlame)}}{{/* IsViewDirectory (not home), TODO: split the templates, avoid using "if" tricks */}} |
There was a problem hiding this comment.
You forgot to commit the suggestion.
There was a problem hiding this comment.
Really ? I do not think I forgot. Why I have to keep explaining everything .........
There was a problem hiding this comment.
Oh ok, I missed b3829ad. GitHub wasn't showing it in the commit list for some reason.
yp05327
approved these changes
Apr 26, 2024
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2024
* giteaofficial/main: feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656) Fix code search input for different views (go-gitea#30678) Fix incorrect object id hash function (go-gitea#30708) Add route handler info for debugging purpose (go-gitea#30705) Bump htmx version to 1.9.12 (go-gitea#30711)
wxiaoguang
added
the
skip-changelog
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 27, 2024
* origin/main: Replace deprecated `math/rand` functions (go-gitea#30733) Make Ctrl+Enter work for issue/comment edit (go-gitea#30720) Rename migration package name for 1.22-rc1 (go-gitea#30730) Issue card improvements (go-gitea#30687) Don't show loading indicators when refreshing the system status (go-gitea#30712) Add some tests to clarify the "must-change-password" behavior (go-gitea#30693) Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686) Update JS dependencies (go-gitea#30713) Improve diff stats bar (go-gitea#30669) Remove unused parameter for some functions in `services/mirror` (go-gitea#30724) Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573) Suppress browserslist warning in webpack target (go-gitea#30571) [skip ci] Updated translations via Crowdin Diff color enhancements, add line number background (go-gitea#30670) feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656) Fix code search input for different views (go-gitea#30678) Fix incorrect object id hash function (go-gitea#30708)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now only show the "code search" on the repo home page, because it only does global search.
So do not show it when viewing file or directory to avoid misleading users (it doesn't search in a directory)