Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue card improvements #30687

Merged
merged 5 commits into from
Apr 27, 2024
Merged

Issue card improvements #30687

merged 5 commits into from
Apr 27, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 24, 2024 •
edited
Loading

Fixes #30682 and does a few improvements:

  • Use gap instead of margin/padding
  • Don't render empty image div
  • Remove right floated class that did nothing
Screenshot 2024-04-24 at 20 21 20

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 24, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Apr 24, 2024
KN4CK3R
KN4CK3R reviewed Apr 25, 2024
View reviewed changes
templates/repo/issue/card.tmpl Outdated Show resolved Hide resolved
templates/repo/issue/card.tmpl Outdated Show resolved Hide resolved
silverwind and others added 2 commits April 25, 2024 09:43
@silverwind @KN4CK3R
Update templates/repo/issue/card.tmpl
aaf0bbb 
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@silverwind @KN4CK3R
Update templates/repo/issue/card.tmpl
8b73362 
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2024
@silverwind silverwind requested a review from wxiaoguang April 27, 2024 11:51
wxiaoguang
wxiaoguang approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think these tw- tricks are good enough, meanwhile I can accept it as a temporary fix.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2024
@silverwind
Copy link
Member Author

The only "trick" here is tw-gap-[5px], but I felt the need to have such a specific value there.

@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2024
@silverwind silverwind enabled auto-merge (squash) April 27, 2024 12:06
@silverwind silverwind merged commit b93c87b into go-gitea:main Apr 27, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 27, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2024
@silverwind silverwind deleted the issuecard branch April 27, 2024 13:58
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
289aed7 
* giteaofficial/main:
  Make Ctrl+Enter work for issue/comment edit (go-gitea#30720)
  Rename migration package name for 1.22-rc1 (go-gitea#30730)
  Issue card improvements (go-gitea#30687)
  Don't show loading indicators when refreshing the system status (go-gitea#30712)
  Add some tests to clarify the "must-change-password" behavior (go-gitea#30693)
  Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686)
  Update JS dependencies (go-gitea#30713)
  Improve diff stats bar (go-gitea#30669)
  Remove unused parameter for some functions in `services/mirror` (go-gitea#30724)
  Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573)
  Suppress browserslist warning in webpack target (go-gitea#30571)
  [skip ci] Updated translations via Crowdin
  Diff color enhancements, add line number background (go-gitea#30670)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 27, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into noext
d98bdfc 
* origin/main:
  Replace deprecated `math/rand` functions (go-gitea#30733)
  Make Ctrl+Enter work for issue/comment edit (go-gitea#30720)
  Rename migration package name for 1.22-rc1 (go-gitea#30730)
  Issue card improvements (go-gitea#30687)
  Don't show loading indicators when refreshing the system status (go-gitea#30712)
  Add some tests to clarify the "must-change-password" behavior (go-gitea#30693)
  Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686)
  Update JS dependencies (go-gitea#30713)
  Improve diff stats bar (go-gitea#30669)
  Remove unused parameter for some functions in `services/mirror` (go-gitea#30724)
  Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573)
  Suppress browserslist warning in webpack target (go-gitea#30571)
  [skip ci] Updated translations via Crowdin
  Diff color enhancements, add line number background (go-gitea#30670)
  feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656)
  Fix code search input for different views (go-gitea#30678)
  Fix incorrect object id hash function (go-gitea#30708)
@silverwind silverwind mentioned this pull request Apr 30, 2024
Closed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R left review comments

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Project board column abel visual bug
5 participants
@silverwind @lunny @KN4CK3R @wxiaoguang @GiteaBot