Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Script dictionary erase is not sequenced. #37477

Closed
fire opened this issue Mar 31, 2020 · 1 comment · Fixed by #37513
Closed

Visual Script dictionary erase is not sequenced. #37477

fire opened this issue Mar 31, 2020 · 1 comment · Fixed by #37513

Comments

@fire
Copy link
Member

fire commented Mar 31, 2020

Godot version:
3.2.1-stable

OS/device including version:
win 10

Issue description:
Dictionary erase in Godot isn't sequenced so the order is undetermined.

@swarnimarun @kidrigger I think it's just a boolean that isn't selected.

Steps to reproduce:

image

Array erase does it properly.

Minimal reproduction project:
New Game Project.zip

@bojidar-bg
Copy link
Contributor

Basically, it should be marked ADDFUNC1RNC here:

ADDFUNC1R(DICTIONARY, BOOL, Dictionary, erase, NIL, "key", varray());

zak-grumbles added a commit to zak-grumbles/godot that referenced this issue Apr 2, 2020
* Updated macro call to make the visual Dictionary Erase node sequenced.
@akien-mga akien-mga added this to the 4.0 milestone Apr 2, 2020
akien-mga pushed a commit to akien-mga/godot that referenced this issue Apr 16, 2020
* Updated macro call to make the visual Dictionary Erase node sequenced.

(cherry picked from commit d648f77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants