Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the default editor font sizes #32061

Closed

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 9, 2019

This makes the editor feel less cramped on smaller displays. The default code font's line spacing was slightly increased to account for its lower size.

Some margins are now slightly increased when using a smaller font size to make list items easier to select.

The output log and About dialog now use the line spacing defined in the script editor settings.

See the discussion in godotengine/godot-proposals#9.

Preview

Editor at 1920×1080 (old font sizes)

editor_font_size_old

Editor at 1920×1080 (new font sizes + spacing compensation)

editor_font_size_new

New default font size and line spacing in the script editor

editor_script_editor_font_size_new

@CptPotato
Copy link
Contributor

I think it's a good change. On my 24" 1080p monitor I'm using an editor font size of 12.
Though, as I don't have any problems with things like clicking list items, is the additional margin you mentioned configurable in the editor settings?

@Calinou
Copy link
Member Author

Calinou commented Sep 11, 2019

@CptPotato I hardcoded it since I'd rather not add yet another setting to the Editor Settings.

When you compare Godot's PopupMenus to the OS' dropdown menus, these are much narrower. This makes dropdown items difficult to select quickly, especially at higher mouse sensitivities.

@CptPotato
Copy link
Contributor

Alright, it probably won't be much of an issue for me.

This makes the editor feel less cramped on smaller displays.
The default code font's line spacing was slightly increased to account
for its lower size.

Some margins are now slightly increased when using a smaller font size
to make list items easier to select.

The output log and About dialog now use the line spacing defined in the
script editor settings.
@Calinou Calinou force-pushed the editor-decrease-default-font-sizes branch from 91572fb to 44c1a8b Compare September 16, 2019 09:26
@Calinou
Copy link
Member Author

Calinou commented Sep 16, 2019

I amended the pull request to decrease the editor help font size to 14 per @Homer666's suggestion.

@akien-mga
Copy link
Member

I'm not so convinced, on a 15" 1080p the proposed new font size is pretty tiny. It's smaller than the default font size of Firefox, or the default font size of my desktop environment.

@akien-mga akien-mga added this to the 3.2 milestone Sep 25, 2019
@fvsch
Copy link

fvsch commented Sep 25, 2019

It's smaller than the default font size of Firefox, or the default font size of my desktop environment.

For reference:

  • Gnome/GTK uses 11pt* = 14.666px by default for UI labels, not sure about KDE
  • VS Code uses 13px for some UI labels (e.g. file names in the file explorer, non configurable), and 12px for code (configurable).

* Some software uses pixels and other use points in their preferences dialogs and documentation. When they use points, it can refer to "system points" (1pt == 1px at 1x, 2px at 2x, etc.), or it can refer to typographic points (12pt = 16px at 1x).

@golddotasksquestions
Copy link

golddotasksquestions commented Oct 2, 2019

The new fontsize is really hard to read for me (1920x1080, 17.3") I would prefer to keep current one which is already very small. I have great eyesight btw and sit in ergonomically recommended distance to the screen.

@akien-mga akien-mga modified the milestones: 3.2, 4.0 Nov 7, 2019
@Calinou
Copy link
Member Author

Calinou commented Nov 16, 2019

I'll close this due to fonts being too small on most laptop displays. We'll have to find other ways to make better use of screen real estate out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants