Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tween null check missing #45405

Closed
wants to merge 1 commit into from
Closed

Tween null check missing #45405

wants to merge 1 commit into from

Conversation

Norrox
Copy link
Contributor

@Norrox Norrox commented Jan 24, 2021 •
edited
Loading

fixes the null check for tween
Resolves #45399

@Norrox Norrox changed the title fixes #45399 Tween null check missing, fixes #45399 Jan 24, 2021
@Norrox Norrox changed the title Tween null check missing, fixes #45399 Tween null check missing Jan 24, 2021
@Calinou Calinou added this to the 3.2 milestone Jan 24, 2021
@Calinou
Copy link
Member

Calinou commented Jan 24, 2021 •
edited
Loading

Thanks for opening a pull request 🙂

Pull requests (especially ones that break backwards compatibility) should be opened against the master branch instead of 3.2. This is because feature development occurs in the master branch. We can then cherry-pick specific PRs to the 3.2 branch if they don't break backwards compatibility.

@Norrox
Copy link
Contributor Author

Norrox commented Jan 25, 2021

Thanks for opening a pull request 🙂

Pull requests (especially ones that break backwards compatibility) should be opened against the master branch instead of 3.2. This is because feature development occurs in the master branch. We can then cherry-pick specific PRs to the 3.2 branch if they don't break backwards compatibility.

ah my bad :D

@Norrox Norrox closed this Jan 25, 2021
@Calinou Calinou removed this from the 3.2 milestone Jan 25, 2021
@Calinou Calinou added this to the 3.2 milestone Jan 25, 2021
@Calinou
Copy link
Member

Calinou commented Jan 25, 2021

Superseded by #45438.

@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug crash topic:core
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Norrox @Calinou @akien-mga