Fix the tween null check #45438
Merged
Fix the tween null check #45438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Calinou is this ok? ;D |
Code looks good to me (apart from the comments below), but I don't merge code pull requests on the main repository. You'll have to wait for Akien to take a look. |
Calinou
previously requested changes
Jan 25, 2021
|
I force pushed a rebase to squash the commits into one and clarify the commit message. |
akien-mga
approved these changes
Feb 24, 2021
akien-mga
added
the
cherrypick:3.x
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
well this fixes the null check for tween for 4.0, the 3.2 code looks a little different so i dont know how to push both to the same master as this is my first time playing around with this :)
fixes #45399 error for version 4