Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project crashes with no errors upon tweening a non existent node #45399

Closed
TheCoolBounana opened this issue Jan 23, 2021 · 1 comment · Fixed by #45438
Closed

Project crashes with no errors upon tweening a non existent node #45399

TheCoolBounana opened this issue Jan 23, 2021 · 1 comment · Fixed by #45438

Comments

@TheCoolBounana
Copy link

Godot version:
3.2.3 stable

OS/device including version:
MacOS 11.0.1 Big Sur, GLES3

Issue description:
I created a tween inside of a script, added it to the scene tree, and tweened a non-existing node. Instead of leaving an error message, the game crashes without a trace in the debugger.

Steps to reproduce:
Create an empty scene, add a root node and add a script to this node, in the script create a new tween and add it to the scene tree. Then you only need to make the tween interpolate a property of a non-existent node and run the project, no need to even call the start() method on the tween. The project immediately crashes when interpolating the property.

Minimal reproduction project:
Bug.zip

@KoBeWi
Copy link
Member

KoBeWi commented Jan 23, 2021

Looks like Tween is missing null checks in interpolate_* methods.

@KoBeWi KoBeWi added the crash label Jan 23, 2021
@TheCoolBounana TheCoolBounana changed the title Project crashes with no errors upon tweening Project crashes with no errors upon tweening a non existent node Jan 23, 2021
This was referenced Jan 25, 2021
@akien-mga akien-mga added this to the 4.0 milestone Feb 24, 2021
akien-mga pushed a commit to akien-mga/godot that referenced this issue Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants