Enable optional minimal SteamAPI integration for usage time tracking (editor only).

[bruvzg]

Disabled by default, can be enabled with (steamapi=yes build option), steam_appid.txt (it's only needed when running executable outside of Steam download) and steam_api library from the SDK should be added to distribution for this feature to work.

It initializes Steam API to inform Steam that Godot editor is running, but not using it in any way.

Fixes #18233

Reopened #56727, GitHub seems to completely ignore force pushes to the branches with "invalid characters", so it was impossible to update original PR.

[YuriSizov]

I haven't followed the original discussion closely, but this would mean that for the official distribution we'd need to compile Linux, macOS, and Windows builds twice with and without this flag?

[bruvzg]

I haven't followed the original discussion closely, but this would mean that for the official distribution we'd need to compile Linux, macOS, and Windows builds twice with and without this flag?

The Steam library is loaded dynamically, so a single build with flag will work fine without Steam. But I guess we do not want official non-Steam builds to have the ability to automatically load proprietary code, so probably yes.

[akien-mga]

I finally took the time to test this (rebased on current master), and I'm having issues initializing the steam_api64.dll library on Windows, from latest Steamwork SDK 1.59:

 ERROR: Can't resolve symbol SteamAPI_Init, error: "Error 127: The specified procedure could not be found.".
   at: (platform\windows\os_windows.cpp:497)

That seems weird as it's indeed present in the public headers for the SDK version.

[bruvzg]

Seems like it's SteamAPI_InitFlat in the newer Steamworks SDKs (SteamAPI_Init is defined as a wrapper in the header only).

[akien-mga]

Indeed, I tested with SteamAPI_InitEx as you mentioned first, but that also didn't work.
With SteamAPI_InitFlat (added in 1.59 which I'm using), it seems to work fine.

So I could test that when running it through Steam, this fixes the time tracking issue.

On the other hand, successfully init'ing the Steam API seems to prevent running the binary from the command line:

PS C:\Program Files (x86)\Steam\steamapps\common\Godot Engine> .\godot.windows.opt.tools.64.exe --verbose
PS C:\Program Files (x86)\Steam\steamapps\common\Godot Engine> Loaded SteamAPI library
ERROR: Parameter "mem" is null.
   at: Memory::realloc_static (core\os\memory.cpp:130)
ERROR: Parameter "mem" is null.
   at: Memory::realloc_static (core\os\memory.cpp:130)

(no window shows up)

Is that something we could address somehow so we get the benefit when in Steam, but not the drawbacks otherwise?

Maybe there's an env variable set by Steam which we can check to know whether to bother init'ing the Steam API in the first place?

[bruvzg]

Updated, but have not tested, will do it tomorrow.

[bruvzg]

Tested it (on macOS and Windows, both 32-bit and 64-bit), seems to work fine.

In the other hand, successfully init'ing the Steam API seems to prevent running the binary from the command line

I can't reproduce it. This might be memory corruption, since new function require fixed size string buffer, if you replaced only the function name it might write over some other data.

[akien-mga]

I can't reproduce it. This might be memory corruption, since new function require fixed size string buffer, if you replaced only the function name it might write over some other data.

Yeah I had just replaced the function name so that's probably why.

I'll test the new version asap.

[akien-mga]

Tested on Windows and Linux, seems to work well.

On Linux, time tracking was already working fine and doesn't regress.
On Windows, this PR solves the time tracking issue.

[akien-mga]

Thanks!