GDScript: Hot-reload changed scripts only #86676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnen
requested changes
Jan 2, 2024
rune-scape
force-pushed
the
sparse-script-reload
branch
from
f1fa6d7 to
cde478b
Compare
| @@ -478,6 +478,7 @@ class CSharpLanguage : public ScriptLanguage { | |||
| /* TODO? */ void get_public_annotations(List<MethodInfo> *p_annotations) const override {} | |||
|
|
|||
| void reload_all_scripts() override; | |||
| void reload_scripts(const Array &p_scripts, bool p_soft_reload) override; | |||
There was a problem hiding this comment.
Suggested change
| void reload_scripts(const Array &p_scripts, bool p_soft_reload) override; | |
| virtual void reload_scripts(const Array &p_scripts, bool p_soft_reload) override; |
This isn't done consistently here but should be done here when adding new entries IMO, it's done on some methods already above
There was a problem hiding this comment.
This would only matter if someone was to extend CSharpLanguage, which is highly unlikely. So I'd say this is a non-blocking issue.
There was a problem hiding this comment.
No I mean that we always use virtual and override as a matter of style regularity, unless it's marked final it doesn't matter for that sense
|
Thanks! |
rune-scape
pushed a commit
to rune-scape/godot
that referenced
this pull request
Jun 3, 2024
…load GDScript: Hot-reload changed scripts only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hot reloading currently reloads all scripts
when working with dosens of scripts, it means a small change can take take a while, even tho you just wanted 1 script reloaded
with this PR only changed scripts are reloaded
was not sure how to change
godot_icall_Internal_EditorDebuggerNodeReloadScriptscsharp interop, so i left the behavior unchanged