Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virtual binding for ScriptLanguageExtension::_reload_scripts #95730

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix virtual binding for ScriptLanguageExtension::_reload_scripts #95730

merged 1 commit into from
Aug 19, 2024

Conversation

voidedWarranties
Copy link
Contributor

@voidedWarranties voidedWarranties commented Aug 18, 2024 •
edited by AThousandShips
Loading

@voidedWarranties voidedWarranties requested review from a team as code owners August 18, 2024 04:15
@Chaosus Chaosus added this to the 4.4 milestone Aug 18, 2024
@Chaosus Chaosus added bug and removed enhancement labels Aug 18, 2024
@raulsntos raulsntos mentioned this pull request Aug 19, 2024
Closed
@AThousandShips AThousandShips added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 19, 2024
@akien-mga akien-mga merged commit ab2b06b into godotengine:master Aug 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@voidedWarranties voidedWarranties deleted the fix_reload_scripts_bind branch August 19, 2024 19:24
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:gdextension
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Required virtual method ScriptLanguageExtension::_reload_scripts must be overidden
4 participants
@voidedWarranties @akien-mga @Chaosus @AThousandShips