Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin/arm64 is now ignored by goreleaser0.157+ if go<1.6 #17703

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

pradeepbhadani
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

goreleaser v0.157.0 ignores darwin/arm64 if go<1.6 - https://github.com/goreleaser/goreleaser/releases/tag/v0.157.0, goreleaser/goreleaser#2069

@pradeepbhadani pradeepbhadani requested a review from a team as a code owner February 19, 2021 11:23
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. labels Feb 19, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 19, 2021
@bflad bflad self-assigned this Feb 19, 2021
@bflad bflad added provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 19, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference: #17685

This is probably okay to merge now, but out of caution will pull this in after #17655.

@bflad bflad merged commit 4370a5d into hashicorp:main Feb 24, 2021
@github-actions github-actions bot added this to the v3.30.0 milestone Feb 24, 2021
@pradeepbhadani pradeepbhadani deleted the goreleaser-darwin-arm64 branch February 24, 2021 22:54
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Pertains to the provider itself, rather than any interaction with AWS. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants