This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Support exposing jmx and additional ports #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-ok-to-test
|
/assign @benjigoldberg |
There was a problem hiding this comment.
@ethanocentricity couple of minor formatting things, otherwise this looks great.
incubator/kafka/README.md
Outdated
| @@ -70,6 +70,8 @@ following configurable parameters: | |||
| | `external.domain` | Domain in which to advertise Kafka external listeners. | `cluster.local` | | |||
| | `external.init` | External init container settings. | (see `values.yaml`) | | |||
| | `configurationOverrides` | `Kafka ` [configuration setting][brokerconfigs] overrides in the dictionary format | `{ offsets.topic.replication.factor: 3 }` | | |||
| | `jmxPort` | The jmx port to use for brokers. Will expose both the port and set the KAFKA_JMX_PORT env variable. | blank | | |||
| | `additionsPorts` | Additional ports to expose on brokers. Useful when the image exposes metrics (like prometheus, etc.) through a javaagent instead of a sidecar | `{}` | | |||
There was a problem hiding this comment.
additionsPorts -> additionalPorts
incubator/kafka/values.yaml
Outdated
| # Useful when the image exposes metrics (like prometheus, etc.) through a javaagent instead of a sidecar | ||
| additionalPorts: {} | ||
|
|
||
|
|
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
@ethanocentricity if you take care of those handful of comments I made and up the chart version I would be happy to merge this change 👍 |
|
@benjigoldberg Thanks for reminding me... Hopefully it is good to go now. |
# Conflicts: # incubator/kafka/README.md
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benjigoldberg, ethanocentricity The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
joshuacox
added a commit
to joshuacox/charts
that referenced
this pull request
Mar 24, 2018
* upstream/master: (944 commits) Rename service port to http (helm#4442) [stable/neo4j] Change the image of the initContainer examples (helm#4269) move burrow to stable repo (helm#3481) Upgrade kube-state-metrics to 1.2.0, add new collectors (helm#4146) Add review guidelines around pvcs (helm#4223) [stable/parse] Release 0.3.10 (helm#4389) [stable/phabricator] Release 0.5.19 (helm#4433) Support exposing jmx and additional ports (helm#4072) Add default of "" for string comparison (helm#4420) [incubator/kafka] Makes readiness probe configurable (helm#3948) Published stash chart 0.7.0-rc.1 (helm#4410) Enable testing charts with test values (helm#4157) [incubator/kafka] Fix initContainer failure which did not error (helm#4400) [stable/etcd-operator] deployment typos and add tolerations (helm#4139) Typo fix in coscale/README.md (helm#4306) Typo fix in concourse/README.md (helm#4303) Typo fix in cockroachdb/README.md (helm#4302) [stable/jenkins] Bump appVersion (helm#4177) Typo fix in cluster-autoscaler/README.md (helm#4301) [stable/traefik] Bump appVersion to 1.5.4 (helm#4206) ...
rolanddb
pushed a commit
to Eneco/charts
that referenced
this pull request
Apr 9, 2018
* Support exposing jmx and additional ports (for example, prometheus as a java agent) * Increment chart version * FIx typo/formatting * Up chart version * Up chart version
ichtar
pushed a commit
to Bestmile/charts
that referenced
this pull request
May 15, 2018
* Support exposing jmx and additional ports (for example, prometheus as a java agent) * Increment chart version * FIx typo/formatting * Up chart version * Up chart version
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
* Support exposing jmx and additional ports (for example, prometheus as a java agent) * Increment chart version * FIx typo/formatting * Up chart version * Up chart version Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the option of exposing a jmx port and additional ports from the broker container to support monitoring. For example, kafka manager access the jmx metrics directly. Additional ports can be used to expose a prometheus exporter endpoint (when using a docker container that includes the jmx exporter as a java agent for kafka as described here: https://www.robustperception.io/monitoring-kafka-with-prometheus/).
When exposing additional ports, one would presumably create a service to access those ports, but it seemed best to keep that outside of this helm chart since it would complicate things with more conditionals and adding more values related to the additional service ports. It could be done, but it seemed wiser to just stay simple for now.
(PodPresets couldn't be used to add on the desired functionality since the ports are at the container level, not the pod level.)