-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/etcd-operator] deployment typos and add tolerations #4139
[stable/etcd-operator] deployment typos and add tolerations #4139
Conversation
…optional tolerations to deployments. fixed restore pod, service label and selector mismatch
/assign @lachie83 |
trying to add the label /ok-to-test |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution!
{{ toYaml .Values.restoreOperator.tolerations | indent 8 }} | ||
{{- end }} | ||
{{- end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you fix the missing spacing here please?
{{- end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise here.
{{ toYaml .Values.restoreOperator.tolerations | indent 8 }} | ||
{{- end }} | ||
{{- end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you fix the missing spacing here.
@@ -15,6 +15,6 @@ spec: | |||
name: http-etcd-restore-port | |||
port: {{ .Values.restoreOperator.port }} | |||
selector: | |||
app: {{ template "etcd-restore-operator.name" . }} | |||
app: {{ template "etcd-restore-operator.fullname" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double check if we mean fullname vs. name.
@@ -15,6 +15,6 @@ spec: | |||
name: http-etcd-restore-port | |||
port: {{ .Values.restoreOperator.port }} | |||
selector: | |||
app: {{ template "etcd-restore-operator.name" . }} | |||
app: {{ template "etcd-restore-operator.fullname" . }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be name
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the purpose of the change was to match the pod label for etcd-restore-operator
here . I was seeing an issue where no endpoints were added for restore operator service, because they selector didn't match the actual pod labels. Are you saying we should change restore operator app
label to name
instead?
…e` instead of `fullname`
@peter-bitfusion please increment patch version. |
@alejandroEsc @unguiculus thanks for the review and input! |
{{ toYaml .Values.backupOperator.tolerations | indent 8 }} | ||
{{- end }} | ||
{{- end}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a space here also, sorry about this.
/assign |
@alejandroEsc thanks for the review. Please be sure to use /lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alejandroEsc, lachie83, peter-bitfusion The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* upstream/master: (944 commits) Rename service port to http (helm#4442) [stable/neo4j] Change the image of the initContainer examples (helm#4269) move burrow to stable repo (helm#3481) Upgrade kube-state-metrics to 1.2.0, add new collectors (helm#4146) Add review guidelines around pvcs (helm#4223) [stable/parse] Release 0.3.10 (helm#4389) [stable/phabricator] Release 0.5.19 (helm#4433) Support exposing jmx and additional ports (helm#4072) Add default of "" for string comparison (helm#4420) [incubator/kafka] Makes readiness probe configurable (helm#3948) Published stash chart 0.7.0-rc.1 (helm#4410) Enable testing charts with test values (helm#4157) [incubator/kafka] Fix initContainer failure which did not error (helm#4400) [stable/etcd-operator] deployment typos and add tolerations (helm#4139) Typo fix in coscale/README.md (helm#4306) Typo fix in concourse/README.md (helm#4303) Typo fix in cockroachdb/README.md (helm#4302) [stable/jenkins] Bump appVersion (helm#4177) Typo fix in cluster-autoscaler/README.md (helm#4301) [stable/traefik] Bump appVersion to 1.5.4 (helm#4206) ...
* stable etcd chart: fixed deployment typo extra space in yamls. added optional tolerations to deployments. fixed restore pod, service label and selector mismatch * fixed {{- end}} typos. changed restore operator app label to use `name` instead of `fullname` * incremented chart patch * (fix): add consistent space
* stable etcd chart: fixed deployment typo extra space in yamls. added optional tolerations to deployments. fixed restore pod, service label and selector mismatch * fixed {{- end}} typos. changed restore operator app label to use `name` instead of `fullname` * incremented chart patch * (fix): add consistent space
* stable etcd chart: fixed deployment typo extra space in yamls. added optional tolerations to deployments. fixed restore pod, service label and selector mismatch * fixed {{- end}} typos. changed restore operator app label to use `name` instead of `fullname` * incremented chart patch * (fix): add consistent space Signed-off-by: voron <av@arilot.com>
What this PR does / why we need it:
there are some typos in the deployments in latest. this pr fixes those and adds the option to add tolerations to deployments.
spec.containers[0].command[0]
app
label on restore operator pod is{{ template "etcd-restore-operator.fullname" . }}
, but the selector on restore operator service is{{ template "etcd-restore-operator.name" . }}
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: