Enable testing charts with test values #4157

unguiculus · 2018-03-14T21:01:02Z

What this PR does / why we need it:

Enables testing charts with test values.

The first commit refactors changed.sh. I ran Shellcheck across it and applied fixes. Some variable were upper, some were lower case. I made that consistent: lower case for script variables, upper case for environment variables.
The second commit updates changed.sh such that the script installs and tests the chart for any *-values.yaml found in the ci folder within the chart's directory.

Which issue this PR fixes:

Fixes #3943

unguiculus · 2018-03-14T21:46:23Z

/retest

unguiculus · 2018-03-15T07:16:34Z

I added a simple chart with a test that just logs a value. The ci folder contains two values files. The chart is installed and tested twice, once for each of the values files. You can verif that by the different test output in the CI log. The chart will be removed before merging.

You may want to review the commits separately. The actual change in logic is in the second commit.

cc @kubernetes/charts-maintainers @kubernetes/helm-maintainers

mattfarina

These are my quick nits and questions. I'll do a little more testing. I generally like the direction.

mattfarina · 2018-03-15T19:41:44Z

.editorconfig

+charset = utf-8
+
+[*.{yml,yaml}]
+indent_size = 2


While I'm a fan of editorconfig to bring about consistency, is there a reason it's in this PR? I ask because it doesn't seem to fit everything else.

I agree. This is unrelated. I'll remove it.

mattfarina · 2018-03-15T19:49:03Z

test/README.md

-"ok-to-test" label. This can also be done by commenting "/ok-to-test" on the pull request. 
+In order for the tests to be kicked off one of the
+[Kubernetes member](https://github.com/orgs/kubernetes/people) must add the
+"ok-to-test" label. This can also be done by commenting "/ok-to-test" on the pull request.


The tests are triggered automatically when someone is a member of the Kubernetes GitHub org or when a member adds the like /ok-to-test is a comment to tell the bot it's ok. Could we get the docs updated to reflect. both cases?

Not related to this PR, but I'll change that.

mattfarina · 2018-03-16T13:49:37Z

test/changed.sh


 # Exit early if no charts have changed
-if [ -z "$CHANGED_FOLDERS" ]; then
-  exit 0
+if [[ -z "$changed_folders" ]]; then


I noticed you changed the casing on variables in the shell script. If I understand the k8s practice, which I could be wrong about, uppercase variables are for those which are not mutated (essentially constants) and lowercase variables are the ones that change (e.g., in loops). It might be good to follow that convention. Thoughts?

I'm all for conventions. In any case the casing was a mixture and not clear as it was. To me, a constant is something that is explicitly initialized as such. It should then probably be made readonly as well. The question is whether any variable qualifies as a constant in its actual sense just because it is never changed after it was assigned. According to Google's Shell Style Guide, a constant should be declared at the top of the file. I would agree with that and would change the casing back where this applies.

mattfarina · 2018-03-16T13:57:15Z

I cleaned these up manually but it doesn't look like cleanup is happening.

unguiculus · 2018-03-16T23:51:30Z

You can see in the log that clean-up happens. I bet these are leftovers from my tests when clean-up failed in some cases.

test/changed.sh

mattfarina · 2018-03-22T13:54:29Z

/lgtm

k8s-ci-robot · 2018-03-22T13:54:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattfarina, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mattfarina,unguiculus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* upstream/master: (944 commits) Rename service port to http (helm#4442) [stable/neo4j] Change the image of the initContainer examples (helm#4269) move burrow to stable repo (helm#3481) Upgrade kube-state-metrics to 1.2.0, add new collectors (helm#4146) Add review guidelines around pvcs (helm#4223) [stable/parse] Release 0.3.10 (helm#4389) [stable/phabricator] Release 0.5.19 (helm#4433) Support exposing jmx and additional ports (helm#4072) Add default of "" for string comparison (helm#4420) [incubator/kafka] Makes readiness probe configurable (helm#3948) Published stash chart 0.7.0-rc.1 (helm#4410) Enable testing charts with test values (helm#4157) [incubator/kafka] Fix initContainer failure which did not error (helm#4400) [stable/etcd-operator] deployment typos and add tolerations (helm#4139) Typo fix in coscale/README.md (helm#4306) Typo fix in concourse/README.md (helm#4303) Typo fix in cockroachdb/README.md (helm#4302) [stable/jenkins] Bump appVersion (helm#4177) Typo fix in cluster-autoscaler/README.md (helm#4301) [stable/traefik] Bump appVersion to 1.5.4 (helm#4206) ...

* Refactor and fix shellcheck issues * Make constants readonly and uppercase * Remove .editorconfig * Enable testing charts with test values * Remove dummy chart

* Refactor and fix shellcheck issues * Make constants readonly and uppercase * Remove .editorconfig * Enable testing charts with test values * Remove dummy chart Signed-off-by: voron <av@arilot.com>

unguiculus force-pushed the feature/test-values branch from 73ffb51 to a1a8820 Compare March 14, 2018 21:04

Refactor and fix shellcheck issues

2cec6cc

unguiculus force-pushed the feature/test-values branch 5 times, most recently from 0a57940 to 569ca27 Compare March 14, 2018 21:41

unguiculus force-pushed the feature/test-values branch 5 times, most recently from f6039c8 to 4c08467 Compare March 15, 2018 07:03

unguiculus force-pushed the feature/test-values branch from 4c08467 to 5783d09 Compare March 15, 2018 07:58

mattfarina reviewed Mar 16, 2018

View reviewed changes

unguiculus added 3 commits March 18, 2018 12:57

Make constants readonly and uppercase

3ad8480

Remove .editorconfig

fc57843

Enable testing charts with test values

8aab3b0

unguiculus force-pushed the feature/test-values branch 4 times, most recently from 88dfdd7 to 9b153d5 Compare March 18, 2018 12:37

Merge remote-tracking branch 'upstream/master' into feature/test-values

72752a8

unguiculus force-pushed the feature/test-values branch from 9b153d5 to 72752a8 Compare March 19, 2018 08:07

prydonius mentioned this pull request Mar 19, 2018

When tests fail fetching description of each pod #4278

Merged

Merge remote-tracking branch 'upstream/master' into feature/test-values

7a02c21

mattfarina reviewed Mar 19, 2018

View reviewed changes

test/changed.sh Show resolved Hide resolved

Remove dummy chart

909517a

unguiculus changed the title ~~[WIP] Enable testing charts with test values~~ Enable testing charts with test values Mar 19, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2018

k8s-ci-robot assigned mattfarina Mar 22, 2018

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2018

k8s-ci-robot merged commit b5c3e51 into helm:master Mar 22, 2018

unguiculus deleted the feature/test-values branch March 22, 2018 20:53

jpoon mentioned this pull request Mar 22, 2018

[stable/ethereum] Add Chart for Deploying Private Ethereum Network #3220

Merged

compleatang mentioned this pull request Mar 24, 2018

[stable/burrow] move placeholder keys and genesis.json to ci folder #4448

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable testing charts with test values #4157

Enable testing charts with test values #4157

unguiculus commented Mar 14, 2018 •

edited

Loading

unguiculus commented Mar 14, 2018 •

edited

Loading

unguiculus commented Mar 15, 2018

mattfarina left a comment

mattfarina Mar 15, 2018

unguiculus Mar 16, 2018

mattfarina Mar 15, 2018

unguiculus Mar 16, 2018 •

edited

Loading

mattfarina Mar 16, 2018

unguiculus Mar 16, 2018

mattfarina commented Mar 16, 2018

unguiculus commented Mar 16, 2018

mattfarina commented Mar 22, 2018

k8s-ci-robot commented Mar 22, 2018

Enable testing charts with test values #4157

Enable testing charts with test values #4157

Conversation

unguiculus commented Mar 14, 2018 • edited Loading

unguiculus commented Mar 14, 2018 • edited Loading

unguiculus commented Mar 15, 2018

mattfarina left a comment

Choose a reason for hiding this comment

mattfarina Mar 15, 2018

Choose a reason for hiding this comment

unguiculus Mar 16, 2018

Choose a reason for hiding this comment

mattfarina Mar 15, 2018

Choose a reason for hiding this comment

unguiculus Mar 16, 2018 • edited Loading

Choose a reason for hiding this comment

mattfarina Mar 16, 2018

Choose a reason for hiding this comment

unguiculus Mar 16, 2018

Choose a reason for hiding this comment

mattfarina commented Mar 16, 2018

unguiculus commented Mar 16, 2018

mattfarina commented Mar 22, 2018

k8s-ci-robot commented Mar 22, 2018

unguiculus commented Mar 14, 2018 •

edited

Loading

unguiculus commented Mar 14, 2018 •

edited

Loading

unguiculus Mar 16, 2018 •

edited

Loading