feat: key management support #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharley
force-pushed
the
jharley.api-keys-support
branch
5 times, most recently
from
6ed858a to
97e086b
Compare
jharley
commented
Jul 16, 2024
| HONEYCOMB_DATASET: testacc | ||
| HONEYCOMB_ENVIRONMENT_ID: hcaen_01j1d7t02zf7wgw7q89z3t60vf # TODO: remove and do a lookup or create in tests |
There was a problem hiding this comment.
will drop these (here and below) when the v2client has Environments API support
jharley
force-pushed
the
jharley.api-keys-support
branch
from
97e086b to
9bf24f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 82.62% 80.36% -2.27%
==========================================
Files 63 67 +4
Lines 4478 5174 +696
==========================================
+ Hits 3700 4158 +458
- Misses 607 753 +146
- Partials 171 263 +92 ☔ View full report in Codecov by Sentry. |
jharley
added
feature
cewkrupa
reviewed
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds V2 API client support and a new V2 API resource
honeycombio_api_keyto the provider. Includes docs updates for the new provider-level config. options as well as the new resource.Left a few follow-up "TODOs" (and removed use of
context.TODO()so I could find the actual TODOs more easily 🙃).This is larger than I'd initially suspected: allowing the provider to work "v1+v2", "v1 only", or "v2 only" required a fair bit of initialization plumbing updates but I have tried to cover that off with test cases.