Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup static environment ID in favour of new functionality #502

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Jul 19, 2024

A follow-up to #501 and #496, this cleans up the various environment-related TODOs.

@jharley jharley added the refactor Internal improvements. label Jul 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.10%. Comparing base (1018f58) to head (c353aa9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #502   +/-   ##
=======================================
  Coverage   80.10%   80.10%           
=======================================
  Files          72       72           
  Lines        5554     5554           
=======================================
  Hits         4449     4449           
  Misses        812      812           
  Partials      293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley marked this pull request as ready for review July 19, 2024 14:01
@jharley jharley requested a review from a team as a code owner July 19, 2024 14:01
@jharley jharley merged commit 65835ee into main Jul 19, 2024
6 checks passed
@jharley jharley deleted the jharley.cleanup-env-testcode branch July 19, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Internal improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants