Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: environment management support #501

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Conversation

jharley
Copy link
Collaborator

@jharley jharley commented Jul 17, 2024

Adds the ability to manage a team's Environments ✨ by introducing a pair of data sources and a shiny new resource.


@jharley jharley added the feature This issue wants to add new functionality. label Jul 17, 2024
@jharley jharley force-pushed the jharley.feat-environments branch from e017ccf to db362df Compare July 18, 2024 01:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 75.81395% with 104 lines in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (3ecd18f) to head (72fe570).

Files Patch % Lines
internal/provider/environment_resource.go 72.19% 38 Missing and 14 partials ⚠️
client/v2/environments.go 57.74% 21 Missing and 9 partials ⚠️
internal/provider/environments_data_source.go 80.00% 7 Missing and 5 partials ⚠️
internal/provider/environment_data_source.go 89.85% 4 Missing and 3 partials ⚠️
internal/provider/provider.go 60.00% 0 Missing and 2 partials ⚠️
internal/provider/api_key_resource.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   80.36%   80.10%   -0.26%     
==========================================
  Files          67       72       +5     
  Lines        5174     5554     +380     
==========================================
+ Hits         4158     4449     +291     
- Misses        753      812      +59     
- Partials      263      293      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jharley jharley force-pushed the jharley.feat-environments branch 2 times, most recently from 1e6d411 to 69f02ce Compare July 18, 2024 17:01
@jharley jharley force-pushed the jharley.feat-environments branch from 69f02ce to 81a0959 Compare July 18, 2024 19:24
@jharley jharley marked this pull request as ready for review July 18, 2024 20:07
@jharley jharley requested a review from a team as a code owner July 18, 2024 20:07
Copy link
Contributor

@brookesargent brookesargent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good! 😎 Just made a couple grammar/typo suggestions.

docs/data-sources/environment.md Outdated Show resolved Hide resolved
docs/data-sources/environment.md Outdated Show resolved Hide resolved
jharley and others added 2 commits July 19, 2024 08:55
Co-authored-by: Brooke Sargent <brookesargent@honeycomb.io>
@jharley jharley merged commit 1018f58 into main Jul 19, 2024
6 checks passed
@jharley jharley deleted the jharley.feat-environments branch July 19, 2024 13:14
jharley added a commit that referenced this pull request Jul 19, 2024
…502)

A follow-up to #501 and #496, this cleans up the various
environment-related TODOs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue wants to add new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants