Vendor import better error #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new package gb/log. Perhaps one day this can be outsourced to a 3rd party.
Remove log.Errorf, it was only used in one place.
Remove log.Warnf, it was not used.
Refactor logging
Fixes #340 No accessors to change linkmode and buildmode because we don't support anything except buildmode=exe, and linkmode defaults to automatic.
Fixes #366 ``` % gb info GB_PROJECT_DIR="/Users/dfc" GB_SRC_PATH="/Users/dfc/src:/Users/dfc/vendor/src" GB_PKG_DIR="/Users/dfc/pkg/darwin-amd64" GB_BIN_SUFFIX="-darwin-amd64" ```
build: add test for cgo main with .cpp files (extern "C" linkage)
cmd/gb: gb info report pkg path and bin suffix
Fix: Clean working directory
Fixes #372 Use a unique temporary directory for cgo build files.
cgo: use unique directory for build
The gb test command advertises support for all valid flags to gb build (e.g. -P), but the logic which determines which flags should be sent to the test binary was not aware of them and blithely passed them through. Add all valid build flags to the map indicating they are meant for gb and not to passed through.
Avoid passing build flags to test process.
Fixes #375 The test for Package.isMain had a loophole where a main package, being built as a test would be linked. - [ ] Add unit test for Package.isMain
test: do not build a main package called main in test scope
cgo: support cgo packages that use c++
Pin wercker to go 1.4.2 (box v1.3.3)
Refactor Package.Objdir into Workdir(pkg)
Refactor cgoobjdir to cgoworkdir to reflect the Workdir(pkg) change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.