Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker-compose unsupported config: profiles #5007

Closed
cclauss opened this issue Apr 8, 2021 · 1 comment · Fixed by #5009
Closed

Docker-compose unsupported config: profiles #5007

cclauss opened this issue Apr 8, 2021 · 1 comment · Fixed by #5009
Assignees
@cdrini
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]

Comments

@cclauss
Copy link
Contributor

cclauss commented Apr 8, 2021 •
edited
Loading

Related to #4936 which added Docker profiles -- Our server versions of docker-compose do not yet support profiles.

ol-home0% docker-compose --version
docker-compose version 1.25.0, build unknown

https://forums.docker.com/t/unsupported-config-option-for-services-profiles/103767

Support for service profiles was added in docker-compose version 1.28

Evidence / Screenshot (if possible)

Screenshot 2021-04-08 at 14 45 04

Relevant url?

Steps to Reproduce

  1. Go to ...
  2. Do ...
  • Actual:
  • Expected:

Details

  • Logged in (Y/N)?
  • Browser type/version?
  • Operating system?
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders
@cclauss cclauss added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Apr 8, 2021
@cclauss cclauss added the Priority: 2 Important, as time permits. [managed] label Apr 8, 2021
@cclauss
Copy link
Contributor Author

cclauss commented Apr 8, 2021 •
edited
Loading

We updated docker-compose via https://docs.docker.com/compose/install/#upgrading

sudo curl -L "https://github.com/docker/compose/releases/download/1.29.0/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose 
sudo chmod +x /usr/local/bin/docker-compose
docker-compose --version
sudo mv /usr/bin/docker-compose /usr/bin/docker-compose-1.25
sudo ln -s /usr/local/bin/docker-compose /usr/bin/docker-compose
docker-compose --version

@cclauss cclauss closed this as completed Apr 8, 2021
cclauss added a commit that referenced this issue Apr 8, 2021
@cclauss
fix: restart_servers.sh for docker-compose --profile and $HOSTNAME
a7b4f5e 
Fixes #5007
Related to #4936

Correct the docker-compose command and properly set the ___remote___ hostname.

@cdrini  @dhruvmanila
@cclauss cclauss mentioned this issue Apr 8, 2021
Merged
@cdrini cdrini mentioned this issue Aug 12, 2021
Closed
49 tasks
@mekarpeles mekarpeles removed the Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrini cdrini

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: restart_servers.sh for docker-compose --profile and $HOSTNAME internetarchive/openlibrary
3 participants
@mekarpeles @cclauss @cdrini