Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restart_servers.sh for docker-compose --profile and $HOSTNAME #5009

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 8, 2021

Fixes #5007
Related to #4936

Correct the docker-compose command and properly set the remote hostname.

@cdrini @dhruvmanila

Closes #

Technical

Testing

Screenshot

Stakeholders

Fixes #5007
Related to #4936

Correct the docker-compose command and properly set the ___remote___ hostname.

@cdrini  @dhruvmanila
@cclauss cclauss added Module: Docker Issues related to the configuration or use of Docker. [managed] Affects: Configuration Related to the configuration of the dev/staging/prod environments, CI, docker, etc. [managed] labels Apr 8, 2021
@cclauss cclauss added this to the Active Sprint milestone Apr 8, 2021
@cclauss cclauss requested a review from cdrini April 8, 2021 14:43
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! My bad :P

@cdrini cdrini merged commit 402b4cf into master Apr 8, 2021
@cclauss cclauss deleted the Fix-docker-compose---profile branch April 8, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Configuration Related to the configuration of the dev/staging/prod environments, CI, docker, etc. [managed] Module: Docker Issues related to the configuration or use of Docker. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker-compose unsupported config: profiles
2 participants