Use docker-compose profiles + cleanup old volume-mount cludges #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
changed the title
cdrini
added
the
Needs: Special Deploy
cclauss
reviewed
Mar 30, 2021
- Profiles let us simplify the `up` commands needed for each searver - Since we're no longer using volume mounts, we no longer need to `down` before we `up`! Docker should automatically detect that oldev:latest has changed, and restart the right things. - Also, no longer need `make i18n` since the built i18n files are in the image. - Move dev only services to docker-compose.override.yml ; this makes things _way_ less error prone - it's now much harder to accidentally deploy a db service to prod.
cdrini
force-pushed
the
experiment/dc-profiles
branch
from
111ba75 to
0727db5
Compare
cclauss
approved these changes
Mar 30, 2021
cclauss
added a commit
that referenced
this pull request
Apr 8, 2021
Fixes #5007 Related to #4936 Correct the docker-compose command and properly set the ___remote___ hostname. @cdrini @dhruvmanila
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to remove some no longer needed deploy steps now that we no longer mount the repo.
Technical
upcommands needed for each searverdownbefore weup! Docker should automatically detect that oldev:latest has changed, and restart the right things.make i18nsince the built i18n files are in the image.profileis not specified for a service, that service is always started! Don't want that. Added a test to make sure no one accidentally does this.Testing
profiles: ["foo"]to web in docker-compose.yml, andprofiles: []to all other services (also in override)docker-compose --profile foo up -d --no-depsonly starts webscaleprofiles: ["foo"]to web & solr in docker-compose.yml, andprofiles: []to all other services (also in override)docker-compose --profile foo up -d --no-deps --scale web=2starts 2 web nodes, one solr nodeScreenshot
Stakeholders
@cclauss