Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): disable snap login and publishing #1547

Merged
merged 1 commit into from
Jun 9, 2020
Merged

fix(ci): disable snap login and publishing #1547

merged 1 commit into from
Jun 9, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 9, 2020

This PR fixes recent CI failures by reverting #1156

Details

This removes login to the third party service during our CI build and publishes .snap package to github release, instead of snapcraft.io, which breaks CI when tokens expire (example).

Rationale

  • our CI should not log into a third party service on every build
  • publishing to third party package stores should not determine if release build is successful or not
    • it should be a separate step, after successful release build

@lidel
fix(ci): no login to snapcraft
2972b4a 
This removes login to third party service during our CI build
and publishes .snap package to github release, instead of snapcraft.io,
which expires tokens and breaks CI.

Publishing to third party package stores should not determine
if release build is successful or not.

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
jessicaschilling
jessicaschilling approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much.

@lidel
Copy link
Member Author

lidel commented Jun 9, 2020

All green, I'm merging this, to restore CI ASAP.

We can restore automated snapcraft publishing in the future,
but as a separate job, triggered by a successful release.

I don't have spare bandwidth for this, but PRs welcome :-)

@lidel lidel merged commit c9089fc into master Jun 9, 2020
@lidel lidel deleted the fix/disable-automatic-snap-push branch June 9, 2020 22:24
@bertrandfalguiere
Copy link
Contributor

We can restore automated snapcraft publishing in the future,
but as a separate job, triggered by a successful release.
I don't have spare bandwidth for this, but PRs welcome :-)

@lidel
Where do the post-release jobs leave? In other words, where should one look at to restore publishing to Snap?

@lidel
Copy link
Member Author

lidel commented Jun 15, 2020

@bertrandfalguiere There are no periodic jobs defined yet.
Someone would have to create them (either by using third party CI or GithubActions).

@bertrandfalguiere bertrandfalguiere mentioned this pull request Jun 15, 2020
Closed
@lidel lidel mentioned this pull request Jun 19, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicaschilling jessicaschilling jessicaschilling approved these changes

@hacdias hacdias Awaiting requested review from hacdias

@rafaelramalho19 rafaelramalho19 Awaiting requested review from rafaelramalho19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lidel @bertrandfalguiere @jessicaschilling