move dlpack

[yxlao]

This change is 

[update-docs]

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

[pvarvak]

Reviewed 6 of 6 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yxlao)

---

cpp/open3d/core/Tensor.cpp, line 1012 at r2 (raw file):

    o3d_dl_tensor->dl_managed_tensor_.manager_ctx = o3d_dl_tensor;
    o3d_dl_tensor->dl_managed_tensor_.deleter = &Open3DDLManagedTensor::Deleter;

o3d_dl_tensor logic is spread over multiple places (we new it above and set o3d_tensor_ there, and do some more setting here), it is a bit convoluted. Could we put all of this logic into Open3DDLManagedTensor:

static DLManagedTensor* Create(Tensor*, const DLTensor&)

(then we can also make Open3DDLManagedTensor ctor private)
and then we won't have o3d_dl_tensor here and just have

return Open3DDLManagedTensor::Create(this,dl_tensor);

---

cpp/open3d/core/DLPack.h, line 2 at r2 (raw file):

/*!
 *  Copyright (c) 2017 by Contributors

is this file from outside somewhere? if so, can we include URL where it is from (and version id)?
have we made any changes to it? if so, we should add our license here as well so everybody knows that our changes are open source
(note, the above license is lacking in detail, can we provide URL of the license where we got this file from, or include the license here?)

[yxlao]

Reviewable status: 6 of 8 files reviewed, 2 unresolved discussions (waiting on @pvarvak)

---

cpp/open3d/core/Tensor.cpp, line 1012 at r2 (raw file):

Previously, pvarvak wrote…

o3d_dl_tensor logic is spread over multiple places (we new it above and set o3d_tensor_ there, and do some more setting here), it is a bit convoluted. Could we put all of this logic into Open3DDLManagedTensor:
static DLManagedTensor* Create(Tensor*, const DLTensor&)
(then we can also make Open3DDLManagedTensor ctor private)
and then we won't have o3d_dl_tensor here and just have
return Open3DDLManagedTensor::Create(this,dl_tensor);

Done.

---

cpp/open3d/core/DLPack.h, line 2 at r2 (raw file):

Previously, pvarvak wrote…

is this file from outside somewhere? if so, can we include URL where it is from (and version id)?
have we made any changes to it? if so, we should add our license here as well so everybody knows that our changes are open source
(note, the above license is lacking in detail, can we provide URL of the license where we got this file from, or include the license here?)

Done.

[pvarvak]

Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @pvarvak and @yxlao)

---

cpp/open3d/core/Tensor.cpp, line 1012 at r2 (raw file):

Previously, yxlao (Yixing Lao) wrote…

Done.

this still looks like a memory leak without enough context on Deleter() and that dl_managed_tensor_ has a pointer to Open3DDLManagedTensor. Should we have Open3DDLManagedTensor::Create static function that does this? It will be right next to Deleter function (should it be renamed Destroy to match Create?) and we can put a comment that the DLManagedTensor*t that is returned is supposed to be destroyed via t->deleter(t); we can have the same comment on this function as well as that this is what DLPack python object will do

---

cpp/open3d/core/DLPack.h, line 93 at r3 (raw file):

    kDLUInt = 1U,
    kDLFloat = 2U,
    kDLBfloat = 4U,

lets add Open3D license

[germanros1987]

Here is an overview of what got changed by this pull request:

Issues
======
- Added 2
           

Clones added
============
- cpp/tests/core/Tensor.cpp  4
         

See the complete overview on Codacy

[pvarvak]

Reviewed 1 of 1 files at r4, 1 of 1 files at r5.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pvarvak)