Visualization refactor: Open3DViewer and rendering::Scene

[prewettg]

This change is 

[update-docs]

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

[errissa]

Reviewed 5 of 17 files at r1, 79 of 297 files at r2, 21 of 34 files at r3, 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved

[yxlao]

Reviewed 2 of 297 files at r2.
Reviewable status: 38 of 44 files reviewed, all discussions resolved (waiting on @errissa)

[yxlao]

Reviewed 5 of 17 files at r1, 93 of 297 files at r2, 25 of 34 files at r3, 1 of 1 files at r4, 5 of 5 files at r5, 1 of 1 files at r6.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @prewettg)

---

cpp/open3d/visualization/gui/Application.cpp, line 242 at r2 (raw file):

        utility::LogError(
                ("Can't find resource directory: " + impl_->resource_path_)
                        .c_str());

do we need .c_str()?

---

cpp/open3d/visualization/gui/Application.cpp, line 249 at r2 (raw file):

                ("Resource directory does not have Open3D resources: " +
                 impl_->resource_path_)
                        .c_str());

do we need .c_str()?

---

cpp/open3d/visualization/rendering/Material.h, line 51 at r6 (raw file):

    float point_size = 3.f;

    std::shared_ptr<open3d::geometry::Image> albedo_img;

remove open3d::?

---

cpp/open3d/visualization/rendering/Material.h, line 63 at r6 (raw file):

    // Generic material properties
    std::unordered_map<std::string, Eigen::Vector4f> generic_params;
    std::unordered_map<std::string, open3d::geometry::Image> generic_imgs;

remove open3d::?

---

cpp/open3d/visualization/rendering/ModelInteractorLogic.cpp, line 78 at r6 (raw file):

                                       Eigen::Vector3f(1, 1, 1));
        t.translate(-center_of_rotation_);
        // scene_->SetEntityTransform(o, t);

remove commented code? same for the rest of this file

---

cpp/open3d/visualization/rendering/filament/FilamentScene.h, line 29 at r6 (raw file):

#pragma once

#include <filament/LightManager.h>

Is FilamentScene.h is ultimately included in Open3D.h? Can we avoid filament headers in our headers e.g. by forward declarationx?
Otherwise, we'll have to install filament headers together with Open3D installation, which is undesirable.

---

cpp/open3d/visualization/visualizer/GuiWidgets.h, line 43 at r6 (raw file):

};

//----

is the comment necessary?

---

cpp/open3d/visualization/visualizer/GuiWidgets.cpp, line 42 at r6 (raw file):

}

//----

is the comment necessary?

---

cpp/pybind/visualization/rendering/rendering.cpp, line 134 at r6 (raw file):

                         Scene::AddGeometry,
                 "Adds a Geometry with a material to the scene")
            //        .def("add_geometry",

remove commented code?

---

examples/python/GUI/vis-gui.py, line 1 at r6 (raw file):

#!/usr/bin/env python3

if we call ./vis-guil.py without python in front, will this work inside virtualenv?xxxnn

[errissa]

Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @prewettg and @yxlao)

---

cpp/open3d/visualization/rendering/ModelInteractorLogic.cpp, line 78 at r6 (raw file):

Previously, yxlao (Yixing Lao) wrote…

remove commented code? same for the rest of this file

I would like to keep the commented code because I may need to make changes to this file to fix a bug which I plan to do as soon as this PR is merged. I'll be removing (or reviving) the commented code at that point.

[prewettg]

Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @yxlao)

---

cpp/open3d/visualization/gui/Application.cpp, line 242 at r2 (raw file):

Previously, yxlao (Yixing Lao) wrote…

do we need .c_str()?

Yes, LogError is LogError(const char *fmt, ...)

---

cpp/open3d/visualization/gui/Application.cpp, line 249 at r2 (raw file):

Previously, yxlao (Yixing Lao) wrote…

do we need .c_str()?

Yes, same as above

---

cpp/open3d/visualization/rendering/Material.h, line 51 at r6 (raw file):

Previously, yxlao (Yixing Lao) wrote…

remove open3d::?

Done

---

cpp/open3d/visualization/rendering/Material.h, line 63 at r6 (raw file):

Previously, yxlao (Yixing Lao) wrote…

remove open3d::?

Done

---

cpp/open3d/visualization/rendering/filament/FilamentScene.h, line 29 at r6 (raw file):

Previously, yxlao (Yixing Lao) wrote…

Is FilamentScene.h is ultimately included in Open3D.h? Can we avoid filament headers in our headers e.g. by forward declarationx?
Otherwise, we'll have to install filament headers together with Open3D installation, which is undesirable.

No, the Filament*.h files are only included by Filament*.cpp files, and implement the abstract class Scene. The gui files include Scene.h, etc. The Renderer class acts as a factory to produce Scene pointers.

---

cpp/open3d/visualization/visualizer/GuiWidgets.h, line 43 at r6 (raw file):

Previously, yxlao (Yixing Lao) wrote…

is the comment necessary?

Nope, it is a vestigial comment from before the GuiVisualizer refactor. Removed

---

cpp/open3d/visualization/visualizer/GuiWidgets.cpp, line 42 at r6 (raw file):

Previously, yxlao (Yixing Lao) wrote…

is the comment necessary?

Vestigial, removed

---

cpp/pybind/visualization/rendering/rendering.cpp, line 134 at r6 (raw file):

Previously, yxlao (Yixing Lao) wrote…

remove commented code?

Done

---

examples/python/GUI/vis-gui.py, line 1 at r6 (raw file):

Previously, yxlao (Yixing Lao) wrote…

if we call ./vis-guil.py without python in front, will this work inside virtualenv?xxxnn

Yes, except that vis-gui.py doesn't have execute permissions. Is your concern the /usr/bin/env part (which I believe is the accepted shebang for python scripts) or the python3 part? The virtual environments I have been using all have a python3 symlink in venv/bin. But if that's not necessarily the case, I could change it to be python.

[germanros1987]

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 6
- Added 14
           

Complexity increasing per file
==============================
- examples/python/GUI/vis-gui.py  6
         

Clones added
============
- cpp/open3d/visualization/visualizer/GuiSettingsModel.cpp  2
- cpp/open3d/visualization/rendering/Open3DScene.cpp  5
         

Clones removed
==============
+ cpp/open3d/visualization/visualizer/GuiVisualizer.cpp  -5
+ cpp/open3d/visualization/rendering/filament/FilamentScene.cpp  -9
         

See the complete overview on Codacy

[yxlao]

Reviewed 6 of 6 files at r7.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @yxlao)