Github Actions Added to Block PRs from fork/main branch

[varshith257]

Which problem is this PR solving?

• Resolves Create GitHub Action to block PRs from ${fork}/main branch #5271

Description of the changes

• Added the github actions file that check the PR is from main branch of fork and blocks it.

How was this change tested?

• Will be tested

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[varshith257]

@yurishkuro I think this functionality can be tested with dummy PR once it got merged

[yurishkuro]

how do you plan to test?

[varshith257]

@yurishkuro Added the suggestions made.
My plan of approach to test this is first we merge it and check with a dummy PR from my main branch to this repo to check this functionality. If it needs any changes we can revert and make necessary changes.

[yurishkuro]

You need to add a workflow using this action (or just add it to the lint workflow)

[varshith257]

@yurishkuro I think we need to add a new workflow using this action, instead adding into lint workflow

[yurishkuro]

I would start with adding to lint workflow - there's an extra overhead for running more workflows. We can always split it later.

[varshith257]

I would start with adding to lint workflow - there's an extra overhead for running more workflows. We can always split it later.

yeah, it could be good to add it to lint workflow. I too observed there are 20+ workflows :)

[varshith257]

@yurishkuro Done with all necessary changes. Is there anything to add?

[yurishkuro]

Please make sure all commits are signed. See CONTRIBUTING.md

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (ccecb7f) to head (8395f22).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5272   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         339      339           
  Lines       16511    16511           
=======================================
  Hits        15701    15701           
  Misses        621      621           
  Partials      189      189           

Flag	Coverage Δ
cassandra-3.x	26.53% <ø> (ø)
cassandra-4.x	26.53% <ø> (ø)
elasticsearch-5.x	21.77% <ø> (ø)
elasticsearch-6.x	21.75% <ø> (ø)
elasticsearch-7.x	21.84% <ø> (-0.02%)	⬇️
elasticsearch-8.x	21.92% <ø> (-0.02%)	⬇️
grpc-badger	19.23% <ø> (ø)
kafka	14.66% <ø> (ø)
opensearch-1.x	21.84% <ø> (ø)
opensearch-2.x	21.84% <ø> (-0.02%)	⬇️
unittests	92.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[varshith257]

@yurishkuro Signed off

[varshith257]

@yurishkuro Some changes has been done to check the log of fork

[varshith257]

Only checks are failing from PR checks of unit test, kafka, grPC-badager PR workflows

[varshith257]

@yurishkuro It's working fine as intended, here's the log of it:

Prepare all required actions
Run ./.github/actions/block-pr-not-on-main
Run echo "Repo: jaegertracing/jaeger"
  echo "Repo: jaegertracing/jaeger"
  echo "Head Repo: varshith257/jaeger"
  echo "Forked: true"
  echo "Branch: block-pr-from-fork"
  
  if [ "true" == "true" ] && [ "block-pr-from-fork" == 'main' ]; then
    echo "PRs from the main branch of forked repositories are not allowed."
    exit [1](https://github.com/jaegertracing/jaeger/actions/runs/8275146057/job/22641817117?pr=5272#step:8:1)
  fi
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
Repo: jaegertracing/jaeger
Head Repo: varshith[2](https://github.com/jaegertracing/jaeger/actions/runs/8275146057/job/22641817117?pr=5272#step:8:2)[5](https://github.com/jaegertracing/jaeger/actions/runs/8275146057/job/22641817117?pr=5272#step:8:6)[7](https://github.com/jaegertracing/jaeger/actions/runs/8275146057/job/22641817117?pr=5272#step:8:8)/jaeger
Forked: true
Branch: block-pr-from-fork

[varshith257]

@yurishkuro Is there any reason for unit tests workflow is failing?

This workflow working fine in my local machine

[yurishkuro]

Thanks

[yurishkuro]

Test was failing because it's flaky, we have an open ticket for it.

[varshith257]

Test was failing because it's flaky, we have an open ticket for it.

Haven't found any ticket @yurishkuro . It will be grateful if you provide link for it, Would like to contribute to it.