Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JMX to new Jetty 10 jetty-slf4j-impl #4830

Closed
joakime opened this issue Apr 30, 2020 · 1 comment · Fixed by #4839
Closed

Add JMX to new Jetty 10 jetty-slf4j-impl #4830

joakime opened this issue Apr 30, 2020 · 1 comment · Fixed by #4839
Assignees
@joakime
Labels
Enhancement

Comments

@joakime
Copy link
Contributor

joakime commented Apr 30, 2020

Jetty version
10.0.x

Description
Add ability to manage the jetty-slf4j-impl runtime via jmx.
@joakime joakime self-assigned this Apr 30, 2020
joakime added a commit that referenced this issue Apr 30, 2020
@joakime
Issue #4830 - Enabling JMX on jetty-slf4j-impl
67bd321 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime linked a pull request Apr 30, 2020 that will close this issue
Issue #4830 - Enabling JMX on jetty-slf4j-impl #4831
Closed
joakime added a commit that referenced this issue May 1, 2020
@joakime
Issue #4830 - Adding jmx entries for logging-jetty module
c144358 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet added a commit that referenced this issue May 3, 2020
@sbordet
Issue #4830 - Add JMX to new Jetty 10 jetty-slf4j-impl.
d239920 
Alternative implementation that adds JMX support for jetty-slf4j-impl.

This version modifies MBeanContainer to be aware of @mxbean annotations and *MBean and *MXBean interfaces, so it does not require a dependency on jetty-jmx nor on java.management.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 3, 2020
@sbordet
Issue #4830 - Add JMX to new Jetty 10 jetty-slf4j-impl.
f98e2f8 
Updates after review.
Fixed test failures.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime added a commit that referenced this issue May 8, 2020
@joakime
Issue #4830 - Cleaning up Level handling with JettyLevel enum
1c4f05d 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue May 8, 2020
@joakime
Issue #4830 - Ensuring we have Logger ROOT configuration ability
1c2c389 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue May 8, 2020
@joakime
Issue #4830 - Improved notification of configuration mistakes on leve…
69e1d11 
…l names

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
sbordet added a commit that referenced this issue May 8, 2020
@sbordet
Issue #4830 - Add JMX to new Jetty 10 jetty-slf4j-impl.
d6d994d 
Updates after review.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 8, 2020
@sbordet
Issue #4830 - Add JMX to new Jetty 10 jetty-slf4j-impl.
41f6e3d 
Updates after review, take 2.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue May 19, 2020
@sbordet
Merge pull request #4839 from eclipse/jetty-10.0.x-4830-jetty-slf4j-i…
beda43c 
…mpl-with-jmx-2

Issue #4830 - Enabling JMX on jetty-slf4j-impl
@sbordet sbordet linked a pull request May 19, 2020 that will close this issue
Issue #4830 - Enabling JMX on jetty-slf4j-impl #4839
Merged
@sbordet
Copy link
Contributor

sbordet commented May 19, 2020

Implemented in #4839.

@sbordet sbordet closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joakime joakime

Labels
Enhancement
Projects
None yet
Milestone
No milestone
2 participants
@joakime @sbordet