Issue #4830 - Enabling JMX on jetty-slf4j-impl #4839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
…4830-jetty-slf4j-impl-with-jmx
Alternative implementation that adds JMX support for jetty-slf4j-impl. This version modifies MBeanContainer to be aware of @mxbean annotations and *MBean and *MXBean interfaces, so it does not require a dependency on jetty-jmx nor on java.management. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
requested changes
May 3, 2020
| @@ -526,7 +526,7 @@ public void testToString() | |||
| assertThat("Logger.toString", log.toString(), is("JettyLogger:xxx:LEVEL=ERROR")); | |||
|
|
|||
| log.setLevel(JettyLogger.OFF); | |||
| assertThat("Logger.toString", log.toString(), is("JettyLogger:xxx:LEVEL=OFF")); | |||
| assertThat("Logger.toString", log.toString(), is("JettyLogger:xxx:LEVEL=ERROR")); | |||
There was a problem hiding this comment.
In #4831, "OFF" is converted to 999 and 999 is converted to Level.ERROR. So, uhm, why don't we get rid of OFF and just call it ERROR so it conforms to SLF4J?
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/LevelUtils.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/test/java/org/eclipse/jetty/logging/JMXTest.java
Outdated
Show resolved
Hide resolved
jetty-slf4j-impl/src/main/java/org/eclipse/jetty/logging/JettyLoggerFactory.java
Show resolved
Hide resolved
Updates after review. Fixed test failures. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
joakime
changed the title
|
@sbordet mind if I add a few more unit tests to this branch? |
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
…l names Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Updates after review. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Updates after review, take 2. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
|
@sbordet any reason this has not been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@joakime can you please review and compare this alternative implementation?