Issue #4830 - Enabling JMX on jetty-slf4j-impl

[joakime]

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

[sbordet]

@joakime upon further analysis, I think we can do better.

The original problem that led to this solution was that we thought there was no way to access the JettyLoggerFactory, but there actually is a way via standard SLF4J APIs: LoggerFactory.getILoggerFactory().

This means that, like we used to do in 9.4.x, we can do server.addBean(LoggerFactory.getILoggerFactory()) and have the JettyLoggerFactory be part of the component tree and therefore known to MBeanContainer.

What we get wrong is the JMX metadata, since JettyLoggerFactory cannot use the Jetty JMX support.
We should expand the JMX metadata discovery so that it's able to figure out standard JMX mbeans.

With that in place, we don't need to support org.eclipse.jetty.jmx=true since that will be decided by applications (by doing server.addBean(LoggerFactory.getILoggerFactory())) but we still want to support the context property.

I can give it a go, unless you want to.

[sbordet]

@joakime see #4839

[joakime]

Closing in favor of #4839