-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: 2023-07-23 정기 배포 #595
Merged
ci: 2023-07-23 정기 배포 #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue 전략, commit 규칙 추가
docs/ 밑의 .md 파일들 링크 추가
convention, error, gitflow, issue strategy 추가 mkdocs.yml 에 페이지 경로 설정 image/ 디렉토리 imbed
doc => docs
mkdocs build
mkdocs gh-deploy
This reverts commit 142cb9e.
이번에는 정말로.......
ci(pnpm): 캐시 사용 중지
feat: 프로젝트 문서 docs로 이전
* refactor: if문 제거 map과 foreach는 배열이 비어있어도 동작에 영향을 주지 않으므로 제거 * refactor: reduce 사용 * refactor: 객체 변경을 피함 * refactor: 변수명 통일 사용자 명칭이 user와 item으로 다르게 불리던 것을 user로 통일 * refactor: 메서드명을 동작과 일치하게 변경 실제로 유저를 변경하지 않고 대여 기록과 함께 반환하므로 * docs: 메서드 설명 추가 * docs: TODO 추가
* feat(user): 기본 회원가입시 @student.42seoul.kr 금지 * feat(auth): 인트라 회원가입시 비밀번호 uuid로 랜덤 설정 * refactor(auth.controller): change import crypto to node:crypto Co-authored-by: scarf <greenscarf005@gmail.com> * build(package.json): remove uuid Co-authored-by: scarf <greenscarf005@gmail.com> * fix(users.controller): invalid exception code Co-authored-by: scarf <greenscarf005@gmail.com> --------- Co-authored-by: scarf <greenscarf005@gmail.com>
tag 중복 검사 시, where 절에 삭제되지 않은 것에서 검사하도록 변경
* chore: add comment for user Delete API * chore: add comment in user router
tsc에서 paths를 변경하지 않아 추후 번들러로 변경해야 합니다.
* ci: docs job 이름을 deploy와 겹치지 않게 변경 * ci: PR 빌드 가능 여부 테스트 * test: NODE_ENV에서 test값 허용
태그 관리자 용의 api와 일반 사용자 용 api로 분리
nyj001012
approved these changes
Jul 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jimin52
approved these changes
Jul 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㄱㄱ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요