-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis migrations to GitHub actions #353
Labels
Comments
This was referenced Nov 9, 2020
@minrk can you add jupyterhub-bot on PyPI as a maintainer of dockerspawner https://pypi.org/project/dockerspawner/? |
rkdarst
added a commit
to rkdarst/batchspawner
that referenced
this issue
Dec 2, 2020
- Test (with pytest) using Github Actions, since Travis is now limiting free projects. See jupyterhub/team-compass#353 . - Almost a direct translation of current .travis.yml, only minor edits to bring it up to date with some versions. - Remove .travis.yml - Review: - I don't know if codecov is used for anything - Is everyone happy with the python/JH version coverage? - General check for best practices
rkdarst
added a commit
to rkdarst/batchspawner
that referenced
this issue
Dec 2, 2020
- Test (with pytest) using Github Actions, since Travis is now limiting free projects. See jupyterhub/team-compass#353 . - Almost a direct translation of current .travis.yml, only minor edits to bring it up to date with some versions. - Remove .travis.yml - Review: - I don't know if codecov is used for anything - Is everyone happy with the python/JH version coverage? - General check for best practices
This was referenced Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With no reply from Travis still regarding #351, @manics @betatim and I have got started on some migrations.
Reference example
I have worked to provide relevant comments in the GitHub Workflow defined in jupyterhub/jupyterhub#3246 to be of use as a reference example of how things work.
Tips
C.UTF-8
sometimes.jobs.<name>.strategy.fail-fast: false
you avoid letting all variations of the job stop when one of them fail.jobs.<name>.strategy.matrix
you can let a single job definition run multiple times using permutation of variables, or just use a list of predefined sets of combinations to include usingjobs.<name>.strategy.matrix.include
.if
conditions set on them. Example:on.workflow_dispatch
you can get a button to manually run a workflow.git
,pytest
, etc not realize colors are supported, so we need to explicitly dogit --no-pager diff --color
andpytest --color=yes
for example when using those commands.This all relates to this issue: Not a tty actions/runner#241, which wasn't an issue in Travis CI
Repo migration overview
I've added a pypi_password secret for all pypi packages in this list as the jupyterhub-bot PyPI user except for the jupyterhub repo.
The text was updated successfully, but these errors were encountered: