Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Prune eventing-contrib/pkg/channel #1044

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Prune eventing-contrib/pkg/channel #1044

merged 1 commit into from
Mar 19, 2020

Conversation

pierDipi
Copy link
Member

Fixes #974

@pierDipi
Prune eventing-contrib/pkg/channel
b3a3fb5 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 19, 2020
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2020
@knative-prow-robot
Copy link
Contributor

Hi @pierDipi. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lionelvillard
Copy link
Member

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2020
@slinkydeveloper
Copy link
Contributor

/assign

@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2020
@lberk
Copy link
Member

lberk commented Mar 19, 2020

/lgtm
/approve

@lionelvillard
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, lionelvillard, pierDipi, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@knative-prow-robot knative-prow-robot merged commit 3827d38 into knative:master Mar 19, 2020
This was referenced May 19, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matzew matzew Awaiting requested review from matzew

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@lberk lberk

@slinkydeveloper slinkydeveloper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prune eventing-contrib/pkg/channel
6 participants
@pierDipi @knative-prow-robot @lionelvillard @slinkydeveloper @lberk @googlebot