This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Add lberk to approvers #1244
Merged
Add lberk to approvers #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/XS
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, lberk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: knative/eventing#3165
Criteria from https://github.com/knative/community/blob/master/ROLES.md#approver
Reviewer of the codebase for at least 3 months:
First reviews:
[Eventing-Contrib] #712 Nov 7th, 2019
[Eventing] knative/eventing#1601 July 30, 2019
Primary reviewer for at least 10 substantial PRs to the codebase [12].
eventing-contrib:
#1225
#1177
#1107
#1089
#1083
#1063
#1039
#1035
#948
#1117
#871
eventing:
knative/eventing#2759
Reviewed at least 30 PRs to the codebase [32]
eventing-contrib:
#932
#948
#886
#1225
#1223
#1146
#1117
#1107
#1089
#1083
#1063
#1044
#1039
#1035
#1028
#957
#925
#901
#884
#874
#871
#847
#987
#1060
#1112
#845
#843
#712
eventing:
knative/eventing#3070
knative/eventing#2759
knative/eventing#2258
knative/eventing#1601
Nominated by an area lead with no objections from other leads:
@matzew
PRs Authored [36]
eventing-contrib:
https://github.com/knative/eventing-contrib/1168
https://github.com/knative/eventing-contrib/1169
https://github.com/knative/eventing-contrib/1163
https://github.com/knative/eventing-contrib/1156
https://github.com/knative/eventing-contrib/1142
https://github.com/knative/eventing-contrib/1069
https://github.com/knative/eventing-contrib/1043
https://github.com/knative/eventing-contrib/1020
https://github.com/knative/eventing-contrib/956
https://github.com/knative/eventing-contrib/937
https://github.com/knative/eventing-contrib/938
https://github.com/knative/eventing-contrib/902
https://github.com/knative/eventing-contrib/919
https://github.com/knative/eventing-contrib/875
https://github.com/knative/eventing-contrib/877
https://github.com/knative/eventing-contrib/830
https://github.com/knative/eventing-contrib/798
https://github.com/knative/eventing-contrib/788
https://github.com/knative/eventing-contrib/747
https://github.com/knative/eventing-contrib/622
https://github.com/knative/eventing-contrib/399
https://github.com/knative/eventing-contrib/444
https://github.com/knative/eventing-contrib/360
https://github.com/knative/eventing-contrib/326
https://github.com/knative/eventing-contrib/329
eventing:
https://github.com/knative/eventing-contrib/3088
https://github.com/knative/eventing-contrib/3078
https://github.com/knative/eventing-contrib/3046
https://github.com/knative/eventing-contrib/2954
https://github.com/knative/eventing-contrib/3004
https://github.com/knative/eventing-contrib/2703
https://github.com/knative/eventing-contrib/2410
https://github.com/knative/eventing-contrib/1993
https://github.com/knative/eventing-contrib/1572
https://github.com/knative/eventing-contrib/1503
https://github.com/knative/eventing-contrib/1258
Proposals Authored & Submitted:
Eventing contrib vs Sandbox
knative github labels
I'm following the observed pattern of approver status across both
eventing and contrib repos, if that's not appropriate, I'd be happy to
take feedback accordingly!