Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

migrate prometheus off reconciler.Base #1063

Merged
merged 2 commits into from
Mar 24, 2020
Merged

migrate prometheus off reconciler.Base #1063

merged 2 commits into from
Mar 24, 2020

Conversation

n3wscott
Copy link
Contributor

Proposed Changes

  • migrate prometheus off reconciler.Base

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 24, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 24, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
mattmoor
mattmoor reviewed Mar 24, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

prometheus/pkg/reconciler/prometheussource.go Show resolved Hide resolved
@n3wscott
Copy link
Contributor Author

/retest

zipkin did not come up

@lberk
Copy link
Member

lberk commented Mar 24, 2020

/assign

@lberk
Copy link
Member

lberk commented Mar 24, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit dde7a22 into knative:master Mar 24, 2020
This was referenced May 19, 2020
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattmoor mattmoor mattmoor left review comments

@matzew matzew Awaiting requested review from matzew

@syedriko syedriko Awaiting requested review from syedriko

Assignees

@lberk lberk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n3wscott @lberk @knative-prow-robot @mattmoor @googlebot