Fixed kafka source after update to eventing #1223
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/assign |
|
/lgtm |
| @@ -57,7 +57,7 @@ func MakeReceiveAdapter(args *ReceiveAdapterArgs) *v1.Deployment { | |||
| Name: "KAFKA_NET_TLS_ENABLE", | |||
| Value: strconv.FormatBool(args.Source.Spec.Net.TLS.Enable), | |||
| }, { | |||
| Name: "SINK_URI", | |||
| Name: "K_SINK", | |||
There was a problem hiding this comment.
that is the SinkBinding feature ...
Do we no longer need the old, just the new ? or was that all changed ?
There was a problem hiding this comment.
I can't really say why this env changed, i just switched from adapter to adapter/v2 and this happened :)
There was a problem hiding this comment.
right -- just to elaborate on that, the K_SINK is a var in the adapter.EnvConfig and it gets resolved to the sink, so that's why it still properly outputs in the logging.
|
after going through and properly reviewing/testing it |
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Fixes #1209