Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KafkaChannel and NatssChannel to the addressable-resolver ClusterRole. #1601

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Add KafkaChannel and NatssChannel to the addressable-resolver ClusterRole. #1601

merged 1 commit into from
Jul 30, 2019

Conversation

Harwayne
Copy link
Contributor

Proposed Changes

  • Add KafkaChannel and NatssChannel to the addressable-resolver ClusterRole.

Release Note

NONE

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 30, 2019
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 30, 2019
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@Harwayne Harwayne force-pushed the contrib-addressable-resolver branch from e0e0c2f to 1d483c0 Compare July 30, 2019 18:51
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Jul 30, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2019
@Harwayne Harwayne force-pushed the contrib-addressable-resolver branch from 1d483c0 to 881370a Compare July 30, 2019 18:52
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Jul 30, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Harwayne Harwayne force-pushed the contrib-addressable-resolver branch from 881370a to e2778c7 Compare July 30, 2019 18:52
@Harwayne Harwayne marked this pull request as ready for review July 30, 2019 18:53
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2019
@Harwayne
Copy link
Contributor Author

/assign @lberk

@lberk
Copy link
Member

lberk commented Jul 30, 2019

/lgtm
thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@knative-prow-robot knative-prow-robot merged commit 3e5a7df into knative:master Jul 30, 2019
@Harwayne Harwayne deleted the contrib-addressable-resolver branch July 30, 2019 20:10
This was referenced May 19, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devguyio devguyio Awaiting requested review from devguyio

@bbrowning bbrowning Awaiting requested review from bbrowning

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@lberk lberk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Harwayne @googlebot @knative-prow-robot @lberk