Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pingsource finalizer #2759

Merged
merged 4 commits into from
Mar 26, 2020
Merged

add pingsource finalizer #2759

merged 4 commits into from
Mar 26, 2020

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • Add finalizer to ensure internal cache is properly updated.

Release Note

Docs

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 16, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 16, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@n3wscott
Copy link
Contributor

I think the job runner is still the opposite direction we want to go, this PR is a hint that it is too complex.

@lionelvillard
Copy link
Member Author

I know :-)

BTW is it possible to apply genreconciler to data-plane components (eg the in-mem and kafka dispatcher)?

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pingsource/jobrunner/pingsource.go 59.3% 66.7% 7.4

@lberk
Copy link
Member

lberk commented Mar 26, 2020

/assign

@lberk
Copy link
Member

lberk commented Mar 26, 2020

Considering this PR is specifically addressing a review from #2716 (#2716 (comment)) it makes sense to me to include the finalizeKind. IE not a discussion about the overall approach.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e577c1c into knative:master Mar 26, 2020
This was referenced May 19, 2020
Merged
Merged
@lionelvillard lionelvillard deleted the mt-ping-finalizer branch August 28, 2020 15:43
@lionelvillard lionelvillard restored the mt-ping-finalizer branch September 3, 2020 15:41
@lionelvillard lionelvillard deleted the mt-ping-finalizer branch September 3, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@Harwayne Harwayne Awaiting requested review from Harwayne

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@lberk lberk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lionelvillard @n3wscott @knative-metrics-robot @lberk @knative-prow-robot @mattmoor @googlebot