Fetch15 twitter with base64 images #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ありがとうございます．早速試してみます． |
tkmtnt7000
suggested changes
Aug 22, 2022
tkmtnt7000
suggested changes
Aug 22, 2022
|
I tested this feature with kitchen-demo. |
|
@tkmtnt7000 Thanks! tkmtnt7000/jsk_robot#7 |
tkmtnt7000
suggested changes
Aug 22, 2022
Co-authored-by: Naoto Tsukamoto <naototukka0413@gmail.com>
|
I think it's time to merge this PR, so could you please add commit if you have something to update and when you have time? @iory |
|
Thanks. I added commit of upstream jsk-ros-pkg#375 |
|
Thank you for updating. It looks good. |
tkmtnt7000
approved these changes
Aug 25, 2022
|
@tkmtnt7000 Thanks for your review! Merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchでtweetするときにbase64の画像を読み込んで、画像つきでtweetすることを可能にする変更です。
jsk-ros-pkg#375
こちらのPRがupstreamのものです。
@tkmtnt7000
knorth55/jsk_robot#327 こちらのPRでキッチンデモをやってみたときにtweetが画像つきで表示されるのかを確認してみてください。