Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for Python 3.7 #347

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Remove support for Python 3.7 #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
291366d
Remove support for Python3.7
gordonhart Dec 5, 2023
8914b3e
Update docs
gordonhart Dec 5, 2023
68e7b04
Merge branch 'trunk' into gh/remove-3.7
gordonhart Dec 14, 2023
c2546dd
Update last supported version
gordonhart Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/continue_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,13 +311,13 @@ workflows:
name: ci-base-<< matrix.python-version >>-<< matrix.extras >>
matrix:
parameters:
python-version: [ "3.7.17", "3.8.18", "3.9.18", "3.10.13", "3.11.6" ]
python-version: [ "3.8.18", "3.9.18", "3.10.13", "3.11.6" ]
extras: ["none", "metrics"]
- unit-test:
name: unit-test-<< matrix.python-version >>-<< matrix.extras >>
matrix:
parameters:
python-version: [ "3.7.17", "3.8.18", "3.9.18", "3.10.13", "3.11.6" ]
python-version: [ "3.8.18", "3.9.18", "3.10.13", "3.11.6" ]
extras: ["none", "metrics"]
requires:
- ci-base-<< matrix.python-version >>-<< matrix.extras >>
Expand Down
16 changes: 8 additions & 8 deletions docs/installing-kolena.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,11 @@ Additional logging can be configured by specifying `initialize(..., verbose=True

`kolena` is compatible with all active Python versions.

| :fontawesome-brands-python: Python Version | :kolena-logo: Compatible `kolena` Versions |
| ----------------------------------------------------------------- |-------------------------------------------------|
| 3.11 | ≥0.69 |
| 3.10 | _All Versions_ |
| 3.9 | _All Versions_ |
| 3.8 | _All Versions_ |
| 3.7 | _All Versions_ |
| 3.6 (EOL: [December 2021](https://devguide.python.org/versions/)) | ≤0.46 |
| :fontawesome-brands-python: Python Version | :kolena-logo: Compatible `kolena` Versions |
|-------------------------------------------------------------------|--------------------------------------------|
| 3.11 | ≥0.69 |
| 3.10 | _All Versions_ |
| 3.9 | _All Versions_ |
| 3.8 | _All Versions_ |
| 3.7 (EOL: [June 2023](https://devguide.python.org/versions/)) | ≤0.99 |
| 3.6 (EOL: [December 2021](https://devguide.python.org/versions/)) | ≤0.46 |
30 changes: 11 additions & 19 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,37 +25,29 @@ packages = [
]

[tool.poetry.dependencies]
python = ">=3.7.1,<3.12"
python = ">=3.8,<3.12"
numpy = [
{ version = ">=1.19", python = ">=3.7,<3.11" },
{ version = ">=1.19", python = ">=3.8,<3.11" },
{ version = ">=1.23", python = ">=3.11" },
]
pandas = [
{ version = ">=1.1,<1.6", python = ">=3.7,<3.11" },
{ version = ">=1.1,<1.6", python = ">=3.8,<3.11" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking question: can this be simplified? something like pandas = "<1.6"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've run into issues with low pandas versions and had to explicitly add the >=1.1 constraint. The different pins for Python 3.11 are necessary (went through this trial-and-error on #7)

{ version = ">=1.5,<1.6", python = ">=3.11" },
]
pandera = ">=0.9.0,<0.16"
pydantic = ">=1.10,<2"
dacite = ">=1.6,<2"
requests = ">=2.20,<2.30" # TODO: revert upper bound when urllib3 situation sorts out: https://github.com/psf/requests/issues/6432
requests-toolbelt = "*"
importlib-metadata = { version = "*", python = "<3.8" }
tqdm = ">=4,<5"
Pillow = [
{ version = "^9.1.1", python = "<3.8" },
{ version = "^10.0.1", python = ">=3.8" },
]
Pillow = "^10.0.1"
retrying = "^1.3.3"
Shapely = "^1.8.5"
deprecation = "^2.1.0"
termcolor = "^1.1.0"
pyarrow = ">=8"
typing-extensions = { version = "^4.5.0", python = "<3.8" }
click = ">=8"
scikit-learn = [
{ version = ">=1.0,<1.0.3", python = ">=3.7.1,<3.8", optional = true },
{ version = ">=1.2,<2", python = ">=3.8", optional = true },
]
scikit-learn = { version = ">=1.2,<2", optional = true }

[tool.poetry.extras]
metrics = ["scikit-learn"]
Expand All @@ -66,12 +58,12 @@ black = { version = "^22.1.0", allow-prereleases = true }
pytest = "^7"
pytest-cov = "^4.0.0"
pytest-depends = "^1.0.1"
mkdocs = { version = "^1.4.3", python = ">=3.8" }
cairosvg = { version = "^2.7.0", python = ">=3.8" }
mkdocs-material = { version = ">=9.2,<10", python = ">=3.8" } # insiders fork installed out-of-band in docs/setup_insiders.sh
mkdocstrings = { version = ">0.20,<1", extras = ["python"], python = ">=3.8" }
mkdocs-git-committers-plugin-2 = { version = "^1", python = ">=3.8" }
mkdocs-git-revision-date-localized-plugin = { version = "^1", python = ">=3.8" }
mkdocs = "^1.4.3"
cairosvg = "^2.7.0"
mkdocs-material = ">=9.2,<10" # insiders fork installed out-of-band in docs/setup_insiders.sh
mkdocstrings = { version = ">0.20,<1", extras = ["python"] }
mkdocs-git-committers-plugin-2 = "^1"
mkdocs-git-revision-date-localized-plugin = "^1"

[tool.poetry.scripts]
kolena = 'kolena._utils.cli:run'
Expand Down