-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Make KWA's main table responsive and add toolbar #1982
UI: Make KWA's main table responsive and add toolbar #1982
Conversation
* Add a top row toolbar with the title of the app and the button to create a new Experiment. * Replace the card with a responsive table that shows the items. The component also has a paginator. Signed-off-by: Elena Zioga <elena@arrikto.com>
05e96a0
to
68ec419
Compare
Update Dockerfile and README file to check out to the commit in master branch from the Kubeflow repository that includes the corresponding changes. Signed-off-by: Elena Zioga <elena@arrikto.com>
@kimwnasptd Can you help with reviewing this PR? /assign @kimwnasptd |
Thanks a lot for these PRs @elenzio9 ! @elenzio9 @kimwnasptd Please can you confirm that after these changes, users can still use Katib UI standalone without Kubeflow Central Dashboard ? |
You're welcome!
I guess you're wondering about this part: https://github.com/kubeflow/katib/pull/1982/files#diff-7119d58aceadee83917f133f98cc4e10036ea1a44e09061ed70f406c675d14faR1. I can confirm that the |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, johnugeorge, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @elenzio9 , it seems that after this PR change the old UI dockerfile can't build locally. Please check the error msg below
could you help take a look? thanks |
@shaowei-su I fixed |
I see, is the old UI build (https://github.com/kubeflow/katib/tree/master/cmd/ui/v1beta1) fully deprecated now? we unfortunately still rely on it due to the issue we are facing described here: #1967 |
Yes, we plan to remove the old UI codes for the next katib release. ref: #1984 (comment) |
In this PR:
Dockerfile
andREADME
file to check out to the commit in master branch from the Kubeflow repository that includes the corresponding changes.Here the new look of the app:
Related PR: kubeflow/kubeflow#6316
Signed-off-by: Elena Zioga elena@arrikto.com