Upgrade run_trial.py and architect.py #2248

sifa1024 · 2023-12-15T08:40:40Z

What this PR does / why we need it:
If I use the original program, I will get this error when running darts-gpu,

<architect.Architect object at 0x7fe597aad780>
Traceback (most recent call last):
  File "/home/sifa/docker/katib/examples/v1beta1/trial-images/darts-cnn-cifar10/run_trial.py", line 259, in <module>
    main()
  File "/home/sifa/docker/katib/examples/v1beta1/trial-images/darts-cnn-cifar10/run_trial.py", line 155, in main
    train(train_loader, valid_loader, model, architect, w_optim, alpha_optim,
  File "/home/sifa/docker/katib/examples/v1beta1/trial-images/darts-cnn-cifar10/run_trial.py", line 194, in train
    architect.unrolled_backward(train_x, train_y, valid_x, valid_y, lr, w_optim)
  File "/home/sifa/docker/katib/examples/v1beta1/trial-images/darts-cnn-cifar10/architect.py", line 69, in unrolled_backward
    self.virtual_step(train_x, train_y, xi, w_optim)
  File "/home/sifa/docker/katib/examples/v1beta1/trial-images/darts-cnn-cifar10/architect.py", line 56, in virtual_step
    vw.copy_(w - torch.FloatTensor(xi) * (m + g + self.w_weight_decay * w))
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!

Which issue(s) this PR fixes

None. I've create pull request directly.

Checklist:

Docs included if any changes are user facing

google-oss-prow · 2023-12-15T08:40:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sifa1024
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tenzen-y

@sifa1024 I apologize for delaying the response.

@kubeflow/wg-automl-leads Could you approve CI?

tenzen-y · 2024-03-04T09:36:53Z

examples/v1beta1/trial-images/darts-cnn-cifar10/architect.py

@@ -26,7 +26,7 @@ def __init__(self, model, w_momentum, w_weight_decay):
        self.w_momentum = w_momentum
        self.w_weight_decay = w_weight_decay

-    def virtual_step(self, train_x, train_y, xi, w_optim):
+    def virtual_step(self, train_x, train_y, xi, w_optim, device):


Instead of passing device name, should we detect device like this?

katib/examples/v1beta1/trial-images/pytorch-mnist/mnist.py

Line 162 in 57e07aa

device = torch.device("cuda" if use_cuda else "cpu")

Yes we should do like this

tenzen-y · 2024-03-04T11:03:48Z

@sifa1024 Could you rebase this PR since we have fixed the CI errors here: #2267.

sifa1024 · 2024-03-04T13:34:58Z

@tenzen-y I modify code and commits and I rebased this PR.

tenzen-y · 2024-03-05T08:26:28Z

@sifa1024 Could you sign to the DCO?

tenzen-y · 2024-03-05T08:40:01Z

@sifa1024 I guess that you need to sign to all commits with git commit -s.

sifa1024 · 2024-03-05T09:14:31Z

sorry I am first time use this....

tenzen-y · 2024-03-05T09:18:39Z

sorry I am first time use this....

@sifa1024 Uhm, could you create a separate PR? It seems that unintended commits are included in this PR.

Signed-off-by: sifa1024 <stu95440@gmail.com>

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Signed-off-by: sifa1024 <stu95440@gmail.com>

* Update Ubuntu to 22.04 for E2E Tests * Update Ubuntu for all Tests Signed-off-by: sifa1024 <stu95440@gmail.com>

* Add Katib ROADMAP 2022/2023 * Add multi-objective optimization * Add Scalability Improvements * Remove Katib CRD naming Signed-off-by: sifa1024 <stu95440@gmail.com>

Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu> Co-authored-by: harrisonfritz <harrisonmichaelfritz@gmail.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Signed-off-by: sifa1024 <stu95440@gmail.com>

#2234) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.15.4 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Bumps [debug](https://github.com/debug-js/debug) from 4.2.0 to 4.3.4. - [Release notes](https://github.com/debug-js/debug/releases) - [Commits](debug-js/debug@4.2.0...4.3.4) --- updated-dependencies: - dependency-name: debug dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

* Fix Optuna Validation for CMA-ES * Fix Optuna test Signed-off-by: sifa1024 <stu95440@gmail.com>

Signed-off-by: sifa1024 <stu95440@gmail.com>

* add env & env_from spec * unify env and env_from specs Signed-off-by: sifa1024 <stu95440@gmail.com>

Signed-off-by: sifa1024 <stu95440@gmail.com>

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

* DB: Add env to skip DB creationˆ * DB: Rename var name & Remove new function * Migration -> Initialization * Remove GetBoolEnvOrDefault * DB: Rearrange dependencies Signed-off-by: sifa1024 <stu95440@gmail.com>

…nd (#2253) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.8 to 1.15.4. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.8...v1.15.4) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Bumps [axios](https://github.com/axios/axios) to 1.6.5 and updates ancestor dependency [wait-on](https://github.com/jeffbski/wait-on). These dependencies need to be updated together. Updates `axios` from 0.27.2 to 1.6.5 - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.27.2...v1.6.5) Updates `wait-on` from 7.0.1 to 7.2.0 - [Release notes](https://github.com/jeffbski/wait-on/releases) - [Commits](jeffbski/wait-on@v7.0.1...v7.2.0) --- updated-dependencies: - dependency-name: axios dependency-type: indirect - dependency-name: wait-on dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Message `close-pr-message` was likely a wrong copy-paste from stale. This aligns `close-` messages. Signed-off-by: sifa1024 <stu95440@gmail.com>

* UT: Replace MXNet example with PyTorch example Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * CI: Replace MXNet examples with PyTorch examples Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Signed-off-by: sifa1024 <stu95440@gmail.com>

Signed-off-by: sifa1024 <m11263004@gemail.yuntech.edu.tw> Signed-off-by: sifa1024 <stu95440@gmail.com>

review-notebook-app · 2024-03-05T09:20:57Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

sifa1024 · 2024-03-05T09:23:21Z

I'm going to turn this closed. I feel like I messed up.

sifa1024 · 2024-03-05T10:09:00Z

@tenzen-y Could I creat a new PR?

tenzen-y · 2024-03-05T10:13:52Z

@tenzen-y Could I creat a new PR?

Sure.

google-oss-prow bot requested a review from anencore94 December 15, 2023 08:40

google-oss-prow bot added the size/S label Dec 15, 2023

google-oss-prow bot requested review from gaocegege and johnugeorge December 15, 2023 08:40

sifa1024 marked this pull request as draft December 21, 2023 19:06

google-oss-prow bot added the do-not-merge/work-in-progress label Dec 21, 2023

sifa1024 marked this pull request as ready for review January 4, 2024 22:28

google-oss-prow bot removed the do-not-merge/work-in-progress label Jan 4, 2024

sifa1024 changed the title ~~Update run_trial.py and architect.py~~ Upgrade run_trial.py and architect.py Jan 17, 2024

tenzen-y reviewed Mar 4, 2024

View reviewed changes

sifa1024 requested a review from tenzen-y March 4, 2024 09:41

tenzen-y mentioned this pull request Mar 4, 2024

Remove MXNet examples #2267

Merged

1 task

andreyvelich and others added 11 commits March 5, 2024 17:19

Bump Katib Python SDK to 0.16.0rc1 version (#2217)

7b2fa06

Signed-off-by: sifa1024 <stu95440@gmail.com>

Add Changelog for Katib v0.16.0-rc.0 (#2204)

824250a

Signed-off-by: sifa1024 <stu95440@gmail.com>

Add Changelog for Katib v0.16.0-rc.1 (#2218)

fc9cfdf

Signed-off-by: sifa1024 <stu95440@gmail.com>

Use the controller-runtime logger in the cert-generator (#2219)

aab1427

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Add Stale GitHub Action (#2220)

ae30912

Signed-off-by: sifa1024 <stu95440@gmail.com>

Run Stale Action Every 5th Hour (#2221)

39d752f

Signed-off-by: sifa1024 <stu95440@gmail.com>

Update Ubuntu to 22.04 for E2E Tests (#2222)

78a7eaf

* Update Ubuntu to 22.04 for E2E Tests * Update Ubuntu for all Tests Signed-off-by: sifa1024 <stu95440@gmail.com>

Add Katib ROADMAP 2022/2023 (#2153)

91b15d6

* Add Katib ROADMAP 2022/2023 * Add multi-objective optimization * Add Scalability Improvements * Remove Katib CRD naming Signed-off-by: sifa1024 <stu95440@gmail.com>

[SDK] Raise more human-readable name conflict exception (#2199)

b862fa6

Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu> Co-authored-by: harrisonfritz <harrisonmichaelfritz@gmail.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Update run_trial.py

cc6981e

Signed-off-by: sifa1024 <stu95440@gmail.com>

Update architect.py

1ff9452

Signed-off-by: sifa1024 <stu95440@gmail.com>

dependabot bot and others added 21 commits March 5, 2024 17:19

Fix Optuna Validation for CMA-ES (#2240)

36cb8b3

* Fix Optuna Validation for CMA-ES * Fix Optuna test Signed-off-by: sifa1024 <stu95440@gmail.com>

Bump Katib Python SDK to 0.16.0 version (#2238)

1fb11ee

Signed-off-by: sifa1024 <stu95440@gmail.com>

Add Changelog for Katib v0.16.0 (#2239)

f48b122

Signed-off-by: sifa1024 <stu95440@gmail.com>

[SDK] Add env & env_from in client tune (#2235)

16a4e2c

* add env & env_from spec * unify env and env_from specs Signed-off-by: sifa1024 <stu95440@gmail.com>

Remove legacy BO code (#2246)

a6eb059

Signed-off-by: sifa1024 <stu95440@gmail.com>

Install typing-extensions v4.6.3 for Optuna (#2251)

312ddf2

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

Add Technical and style guide to the contribution guide (#2250)

7122803

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com> Signed-off-by: sifa1024 <stu95440@gmail.com>

DB: Add environment variable option to skip DB table creationˆ (#2245)

9c34fbb

* DB: Add env to skip DB creationˆ * DB: Rename var name & Remove new function * Migration -> Initialization * Remove GetBoolEnvOrDefault * DB: Rearrange dependencies Signed-off-by: sifa1024 <stu95440@gmail.com>

typo fix stale.yaml (#2257)

4230574

Message `close-pr-message` was likely a wrong copy-paste from stale. This aligns `close-` messages. Signed-off-by: sifa1024 <stu95440@gmail.com>

Update architect.py

7f1f260

Signed-off-by: sifa1024 <stu95440@gmail.com>

Update run_trial.py

c5871d3

Signed-off-by: sifa1024 <stu95440@gmail.com>

Update architect.py

2ef65ed

Signed-off-by: sifa1024 <stu95440@gmail.com>

Update architect.py

1894bed

Signed-off-by: sifa1024 <stu95440@gmail.com>

Update run_trial.py

1ade6cd

Signed-off-by: sifa1024 <stu95440@gmail.com>

Update run_trial.py

7dc5789

Signed-off-by: sifa1024 <stu95440@gmail.com>

Update architect.py

7b519b9

Signed-off-by: sifa1024 <m11263004@gemail.yuntech.edu.tw> Signed-off-by: sifa1024 <stu95440@gmail.com>

google-oss-prow bot added size/XXL and removed size/S labels Mar 5, 2024

sifa1024 marked this pull request as draft March 5, 2024 09:23

google-oss-prow bot added the do-not-merge/work-in-progress label Mar 5, 2024

sifa1024 closed this Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade run_trial.py and architect.py #2248

Upgrade run_trial.py and architect.py #2248

sifa1024 commented Dec 15, 2023

google-oss-prow bot commented Dec 15, 2023

tenzen-y left a comment

tenzen-y Mar 4, 2024

sifa1024 Mar 4, 2024

tenzen-y commented Mar 4, 2024

sifa1024 commented Mar 4, 2024

tenzen-y commented Mar 5, 2024

tenzen-y commented Mar 5, 2024

sifa1024 commented Mar 5, 2024

tenzen-y commented Mar 5, 2024

review-notebook-app bot commented Mar 5, 2024

sifa1024 commented Mar 5, 2024 •

edited

Loading

sifa1024 commented Mar 5, 2024

tenzen-y commented Mar 5, 2024

Upgrade run_trial.py and architect.py #2248

Upgrade run_trial.py and architect.py #2248

Conversation

sifa1024 commented Dec 15, 2023

google-oss-prow bot commented Dec 15, 2023

tenzen-y left a comment

Choose a reason for hiding this comment

tenzen-y Mar 4, 2024

Choose a reason for hiding this comment

sifa1024 Mar 4, 2024

Choose a reason for hiding this comment

tenzen-y commented Mar 4, 2024

sifa1024 commented Mar 4, 2024

tenzen-y commented Mar 5, 2024

tenzen-y commented Mar 5, 2024

sifa1024 commented Mar 5, 2024

tenzen-y commented Mar 5, 2024

review-notebook-app bot commented Mar 5, 2024

sifa1024 commented Mar 5, 2024 • edited Loading

sifa1024 commented Mar 5, 2024

tenzen-y commented Mar 5, 2024

sifa1024 commented Mar 5, 2024 •

edited

Loading