Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Remove reclaim and preempt in deployment #772

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Remove reclaim and preempt in deployment #772

merged 1 commit into from
Apr 18, 2019

Conversation

thandayuthapani
Copy link
Contributor

What this PR does / why we need it:
Remove Reclaim and Preempt from deployment Conf
Which issue(s) this PR fixes
Fixes #770

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from hex108 and k82cn April 15, 2019 06:41
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 15, 2019
@k82cn
Copy link
Contributor

k82cn commented Apr 15, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2019
@k82cn
Copy link
Contributor

k82cn commented Apr 15, 2019

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@k82cn
Copy link
Contributor

k82cn commented Apr 15, 2019

we also need to update the configuration in deployment; and we need a copy for CI.

@thandayuthapani
Copy link
Contributor Author

Have made changes in deployment/volcano/config and the same is being is used by CI

@k82cn
Copy link
Contributor

k82cn commented Apr 15, 2019

We have reclaim/preemption test in CI; how can we pass those CI with depoloyments?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2019
TommyLike
TommyLike reviewed Apr 15, 2019
View reviewed changes
config/kube-batch-conf.yaml
@@ -1,4 +1,4 @@
actions: "reclaim, allocate, backfill, preempt"
actions: "allocate, backfill"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing this file in config folder? Will we deprecate them both?

deployment/volcano/config/kube-batch-ci.conf
@@ -0,0 +1,11 @@
actions: "reclaim, allocate, backfill, preempt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you were going to remove them in this file, not the original file. And if I am right, you need to update testcase as well.

Copy link
Contributor Author

@thandayuthapani thandayuthapani Apr 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since in CI, we need to test every action, deployment used in CI is same as the deployment provided for user. So, I have added new config file for CI which will be loaded only during CI run, when user is deploying using helm it will use default config file which will have allocate, backfill alone, which is our requirement as mentioned in the issue #770

@k82cn
Copy link
Contributor

k82cn commented Apr 18, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, thandayuthapani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8a1aa31 into kubernetes-retired:master Apr 18, 2019
wangyuqing4 pushed a commit to wangyuqing4/volcano-1 that referenced this pull request Apr 30, 2019
Merge branch 'github_190422' into 'master'
f231e93 
[Issue volcano-sh#63] sync code from github / 190422

## related pr


* Add UT cases for Preempt Action | kubernetes-retired/kube-batch#751
>!! need fix bug on allocate/preempt UT
>errors about enqueue


* support extended resource for kube-batch | kubernetes-retired/kube-batch#795
>modity Convert2K8sResource in resources_info.go


* Fix verify | kubernetes-retired/kube-batch#792
>modify manually


* Remove reclaim and preempt in deployment | kubernetes-retired/kube-batch#772
>add enqueue in kube-conf-ci.conf


* Add CheckNodeDiskPressure,CheckNodePIDPressure,CheckNodeMemoryPressur… | kubernetes-retired/kube-batch#800
>!! need fix bug on reclaim UT
>errors about enqueue


* Add UT Cases for Reclaim Action | kubernetes-retired/kube-batch#801

* Prevent memory leak | kubernetes-retired/kube-batch#809

* Migrate duplicated code in nodeorder and predicate plugin | kubernetes-retired/kube-batch#816


## not applied pr

* restore kube-batch | https://github.com/kubernetes-sigs/kube-batch/pull/791/files

* Add Volcano Installation Tutorial Link | https://github.com/kubernetes-sigs/kube-batch/pull/796/files

* Add document for MPI example | https://github.com/kubernetes-sigs/kube-batch/pull/793/files

* Update tutorial.md | https://github.com/kubernetes-sigs/kube-batch/pull/808/files

* Add kubemark support | https://github.com/kubernetes-sigs/kube-batch/pull/810/files

Issues info:
Issue ID: 63
Title: sync code from github / 190422
Issue url: CBU-PaaS/Community/volcano/volcano#63


See merge request CBU-PaaS/Community/volcano/volcano!106
penggu pushed a commit to penggu/kube-batch that referenced this pull request May 14, 2019
@lminzhw
sync PR: kubernetes-retired#772
43dfd93
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
@k8s-ci-robot
Merge pull request kubernetes-retired#772 from thandayuthapani/master
465b921 
Remove reclaim and preempt in deployment
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
@k8s-ci-robot
Merge pull request kubernetes-retired#772 from thandayuthapani/master
bc54549 
Remove reclaim and preempt in deployment
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
@k8s-ci-robot
Merge pull request kubernetes-retired#772 from thandayuthapani/master
1c412bb 
Remove reclaim and preempt in deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TommyLike TommyLike TommyLike left review comments

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removed reclaim & preempt actions in vk-scheduler (kube-batch)
4 participants
@thandayuthapani @k82cn @k8s-ci-robot @TommyLike