Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Prevent memory leak #809

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Conversation

hzxuzhonghu
Copy link
Contributor

Calling done after get to prevent workqueue mem leak.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2019
@k82cn
Copy link
Contributor

k82cn commented Apr 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 19f95af into kubernetes-retired:master Apr 20, 2019
k8s-ci-robot added a commit that referenced this pull request Apr 22, 2019
…ream-release-0.4

Automated cherry pick of #809: Prevent memory leak
wangyuqing4 pushed a commit to wangyuqing4/volcano-1 that referenced this pull request Apr 30, 2019
[Issue volcano-sh#63] sync code from github / 190422

## related pr


* Add UT cases for Preempt Action | kubernetes-retired/kube-batch#751
>!! need fix bug on allocate/preempt UT
>errors about enqueue


* support extended resource for kube-batch | kubernetes-retired/kube-batch#795
>modity Convert2K8sResource in resources_info.go


* Fix verify | kubernetes-retired/kube-batch#792
>modify manually


* Remove reclaim and preempt in deployment | kubernetes-retired/kube-batch#772
>add enqueue in kube-conf-ci.conf


* Add CheckNodeDiskPressure,CheckNodePIDPressure,CheckNodeMemoryPressur… | kubernetes-retired/kube-batch#800
>!! need fix bug on reclaim UT
>errors about enqueue


* Add UT Cases for Reclaim Action | kubernetes-retired/kube-batch#801

* Prevent memory leak | kubernetes-retired/kube-batch#809

* Migrate duplicated code in nodeorder and predicate plugin | kubernetes-retired/kube-batch#816


## not applied pr

* restore kube-batch | https://github.com/kubernetes-sigs/kube-batch/pull/791/files

* Add Volcano Installation Tutorial Link | https://github.com/kubernetes-sigs/kube-batch/pull/796/files

* Add document for MPI example | https://github.com/kubernetes-sigs/kube-batch/pull/793/files

* Update tutorial.md | https://github.com/kubernetes-sigs/kube-batch/pull/808/files

* Add kubemark support | https://github.com/kubernetes-sigs/kube-batch/pull/810/files

Issues info:
Issue ID: 63
Title: sync code from github / 190422
Issue url: CBU-PaaS/Community/volcano/volcano#63


See merge request CBU-PaaS/Community/volcano/volcano!106
penggu pushed a commit to penggu/kube-batch that referenced this pull request May 14, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/scheduler that referenced this pull request Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants