This repository has been archived by the owner on May 25, 2023. It is now read-only.
Fix verify #792
Merged
Fix verify #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
fixes: #788 |
|
Thanks, Now command |
|
any idea the pull-kube-batch-verify failure? |
|
@hzxuzhonghu looks like it's been initialized in kube-batch folder while all import paths are still using volcano :( |
|
/retest |
|
/lgtm |
wangyuqing4
pushed a commit
to wangyuqing4/volcano-1
that referenced
this pull request
Apr 30, 2019
[Issue volcano-sh#63] sync code from github / 190422 ## related pr * Add UT cases for Preempt Action | kubernetes-retired/kube-batch#751 >!! need fix bug on allocate/preempt UT >errors about enqueue * support extended resource for kube-batch | kubernetes-retired/kube-batch#795 >modity Convert2K8sResource in resources_info.go * Fix verify | kubernetes-retired/kube-batch#792 >modify manually * Remove reclaim and preempt in deployment | kubernetes-retired/kube-batch#772 >add enqueue in kube-conf-ci.conf * Add CheckNodeDiskPressure,CheckNodePIDPressure,CheckNodeMemoryPressur… | kubernetes-retired/kube-batch#800 >!! need fix bug on reclaim UT >errors about enqueue * Add UT Cases for Reclaim Action | kubernetes-retired/kube-batch#801 * Prevent memory leak | kubernetes-retired/kube-batch#809 * Migrate duplicated code in nodeorder and predicate plugin | kubernetes-retired/kube-batch#816 ## not applied pr * restore kube-batch | https://github.com/kubernetes-sigs/kube-batch/pull/791/files * Add Volcano Installation Tutorial Link | https://github.com/kubernetes-sigs/kube-batch/pull/796/files * Add document for MPI example | https://github.com/kubernetes-sigs/kube-batch/pull/793/files * Update tutorial.md | https://github.com/kubernetes-sigs/kube-batch/pull/808/files * Add kubemark support | https://github.com/kubernetes-sigs/kube-batch/pull/810/files Issues info: Issue ID: 63 Title: sync code from github / 190422 Issue url: CBU-PaaS/Community/volcano/volcano#63 See merge request CBU-PaaS/Community/volcano/volcano!106
penggu
pushed a commit
to penggu/kube-batch
that referenced
this pull request
May 14, 2019
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/scheduler
that referenced
this pull request
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous verify can not verify code generated other than deepcopy.