Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gce: Update logic for internal LB #15332

Merged
merged 2 commits into from
Jul 9, 2023
Merged

gce: Update logic for internal LB #15332

merged 2 commits into from
Jul 9, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Apr 18, 2023

/cc @justinsb

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider labels Apr 18, 2023
@hakman hakman changed the title gce: Update logic for internal LB WIP gce: Update logic for internal LB Apr 18, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2023
justinsb
justinsb reviewed Apr 18, 2023
View reviewed changes
upup/pkg/fi/cloudup/gcetasks/address.go Outdated
Name: *e.Name,
Address: fi.ValueOf(e.IPAddress),
AddressType: fi.ValueOf(e.IPAddressType),
Purpose: "SHARED_LOADBALANCER_VIP",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to specify this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it, because we have it shared between kops-controller and api-server.

pkg/model/gcemodel/api_loadbalancer.go Outdated
return err
}

if len(b.Cluster.Spec.Networking.Subnets) != 1 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't support multiple subnets? Is it that we would need multiple IPs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure we support multiple subnets. I thought we don't, but I may be wrong.
If that's the case, then yes, we need multiple IPs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinsb Seems we don't support multiple subnets for GCE/GCP:

kops/upup/pkg/fi/cloudup/new_cluster.go

Lines 643 to 646 in 60a2e15

// We don't support multi-region clusters, so we can't have more than one subnet
if len(opt.SubnetIDs) != 1 {
return nil, fmt.Errorf("expected exactly one subnet for GCE, got %d", len(opt.SubnetIDs))
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did something along the lines of supporting multiple subnets, but it's not pretty.

This was referenced Jul 5, 2023
Closed
Merged
@hakman hakman changed the title WIP gce: Update logic for internal LB gce: Update logic for internal LB Jul 7, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2023
@hakman hakman requested a review from justinsb July 7, 2023 17:40
@hakman
Copy link
Member Author

hakman commented Jul 8, 2023

/retest

2 similar comments
@hakman
Copy link
Member Author

hakman commented Jul 8, 2023

/retest

@hakman
Copy link
Member Author

hakman commented Jul 8, 2023

/retest

@justinsb
Copy link
Member

justinsb commented Jul 9, 2023

Thanks @hakman

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2023
@justinsb
Copy link
Member

justinsb commented Jul 9, 2023

BTW I think we also need a firewall rule for access from outside the cluster (but inside the VPC), but we can do that separately

@k8s-ci-robot k8s-ci-robot merged commit 114ac31 into kubernetes:master Jul 9, 2023
This was referenced Jul 15, 2023
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request Jul 15, 2023
@k8s-ci-robot
Merge pull request #15639 from hakman/automated-cherry-pick-of-#15602-#…
494a76c 
…15332-#15611-#15614-#15607-upstream-release-1.27

Automated cherry pick of #15602: gce: Add support for bastions#15332: gce: Update logic for internal LB#15611: gce: Set firewall rules for Internal LBs also#15614: gce: Rename firewall SSH rules for bastion#15607: gce: Use `user-data` instead of `startup-script` metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @justinsb @k8s-ci-robot