Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gce: Use user-data instead of startup-script metadata key #15607

Merged
merged 2 commits into from
Jul 15, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 9, 2023

See: hashicorp/terraform-provider-google#1816

Also: https://cloudinit.readthedocs.io/en/23.2.1/reference/datasources/gce.html

The GCE datasource gets its data from the internal compute metadata server. Metadata can be queried at the URL http://metadata.google.internal/computeMetadata/v1/ from within an instance. For more information see the GCE metadata docs.
user-data and user-data-encoding can be provided to cloud-init by setting those custom metadata keys for an instance.

Closes #15589

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 9, 2023
@hakman
Copy link
Member Author

hakman commented Jul 9, 2023

/cc @justinsb
/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the area/provider/gcp Issues or PRs related to gcp provider label Jul 9, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 9, 2023
@hakman
Copy link
Member Author

hakman commented Jul 13, 2023

/kind office-hours

@justinsb
Copy link
Member

Thanks @hakman - verified that is now generally supported, even on COS which I think was the problem a few years ago.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2023
@hakman
Copy link
Member Author

hakman commented Jul 15, 2023

Thanks @hakman - verified that is now generally supported, even on COS which I think was the problem a few years ago.

Thanks for checking! This will make some people happy. 😄

@k8s-ci-robot k8s-ci-robot merged commit 141a040 into kubernetes:master Jul 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 15, 2023
@hakman hakman deleted the gce_cloud-init branch July 15, 2023 19:06
k8s-ci-robot added a commit that referenced this pull request Jul 15, 2023
…15332-#15611-#15614-#15607-upstream-release-1.27

Automated cherry pick of #15602: gce: Add support for bastions#15332: gce: Update logic for internal LB#15611: gce: Set firewall rules for Internal LBs also#15614: gce: Rename firewall SSH rules for bastion#15607: gce: Use `user-data` instead of `startup-script` metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/office-hours lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIME Headers in Startup Script causing "Command not found" error
3 participants