gce: Add support for bastions #15602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hakman
force-pushed
the
gce_fix_bastions
branch
2 times, most recently
from
81f327f
to
a624119
Compare
k8s-ci-robot
added
size/M
|
/retest |
justinsb
reviewed
Jul 8, 2023
pkg/model/gcemodel/firewall.go
Outdated
| // We specify explicitly so the rule is in IPv6 mode | ||
| ipv6.Disabled = true | ||
| ipv6.SourceRanges = []string{"::/0"} | ||
| if len(ipv4.SourceTags) == 0 { |
There was a problem hiding this comment.
Suggested change
| if len(ipv4.SourceTags) == 0 { | |
| if len(ipv6.SourceTags) == 0 { |
|
One nit with ipv6, but lgtm otherwise /approve |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
lgtm
|
Thanks @justinsb. Nit fixed. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 15, 2023
…15332-#15611-#15614-#15607-upstream-release-1.27 Automated cherry pick of #15602: gce: Add support for bastions#15332: gce: Update logic for internal LB#15611: gce: Set firewall rules for Internal LBs also#15614: gce: Rename firewall SSH rules for bastion#15607: gce: Use `user-data` instead of `startup-script` metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15590
More fixes coming as part of #15332
/cc @justinsb
/assign @justinsb